Summary: | krita crashes when loading a .kra with a mask | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Halla Rempt <halla> |
Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | Keywords: | regression, release_blocker |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/calligra/69fc58bcc4597f725bbf76e94b9e7fd88c6b434d | Version Fixed In: | |
Sentry Crash Report: |
Description
Halla Rempt
2013-04-23 10:58:58 UTC
Git commit 3b035904cab810dff7dddffbe6621745a898f1b1 by Boudewijn Rempt. Committed on 29/04/2013 at 10:29. Pushed by rempt into branch 'master'. Fix loading of images with selection masks. Selections masks call KisMask::selection() in setVisibile, which asserts if there initSelection() hasn't been called yet. But we cannot call initSelection at this stage of loading because we're only creating the node hierarchy, not the binary content yet. So, add a flag "loading" that inhibits that call & all signal emissions. M +5 -3 krita/image/kis_base_node.cpp M +4 -1 krita/image/kis_base_node.h M +6 -4 krita/image/kis_selection_mask.cpp M +1 -1 krita/image/kis_selection_mask.h M +2 -2 krita/ui/flake/kis_shape_layer.cc M +1 -1 krita/ui/flake/kis_shape_layer.h M +1 -1 krita/ui/kra/kis_kra_loader.cpp http://commits.kde.org/calligra/3b035904cab810dff7dddffbe6621745a898f1b1 Git commit 69fc58bcc4597f725bbf76e94b9e7fd88c6b434d by Siddharth Sharma, on behalf of Boudewijn Rempt. Committed on 29/04/2013 at 10:29. Pushed by siddharthsharma into branch 'krita-psd-plugin-siddharth'. Fix loading of images with selection masks. Selections masks call KisMask::selection() in setVisibile, which asserts if there initSelection() hasn't been called yet. But we cannot call initSelection at this stage of loading because we're only creating the node hierarchy, not the binary content yet. So, add a flag "loading" that inhibits that call & all signal emissions. M +5 -3 krita/image/kis_base_node.cpp M +4 -1 krita/image/kis_base_node.h M +6 -4 krita/image/kis_selection_mask.cpp M +1 -1 krita/image/kis_selection_mask.h M +2 -2 krita/ui/flake/kis_shape_layer.cc M +1 -1 krita/ui/flake/kis_shape_layer.h M +1 -1 krita/ui/kra/kis_kra_loader.cpp http://commits.kde.org/calligra/69fc58bcc4597f725bbf76e94b9e7fd88c6b434d |