Summary: | Dolphin title has quotes around it when launching using Docky | ||
---|---|---|---|
Product: | [I don't know] kde | Reporter: | Michael Spencer <sonrisesoftware> |
Component: | general | Assignee: | Unassigned bugs mailing-list <unassigned-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | cfeck |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
URL: | http://i.imgur.com/aPLxzD5.png | ||
Latest Commit: | Version Fixed In: | 4.11 | |
Sentry Crash Report: |
Description
Michael Spencer
2013-04-19 15:06:43 UTC
Thanks for the bug report! (In reply to comment #0) > Exec=dolphin %i -caption "%c" %u If I understand you correctly, you propose to remove the quotes from that line? It seems that the quotes were already there in the very first commit to Dolphin http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=daace0e789c3ea5e8a89e514abb717c9c360fc7f BTW, the quotes around %u were removed earlier because they caused problems, see bug 169016 comment 15. Yes, I thinkthe solution is to remove the quotes around the "%c" part, making it just %c, because I think the quotes result in undefined behavior, as in the case of Docky. I tried it on my own system and it works. (In reply to comment #1) > Thanks for the bug report! > > (In reply to comment #0) > > Exec=dolphin %i -caption "%c" %u > > If I understand you correctly, you propose to remove the quotes from that > line? Yes, I think the solution is to remove the quotes around the "%c" part, making it just %c, because I think the quotes result in undefined behavior, as in the case of Docky. I tried it on my own system and it works. All KDE .desktop files have "%c" instead of %c, Docky should be able to deal with it. (In reply to comment #4) > All KDE .desktop files have "%c" instead of %c, Docky should be able to deal > with it. But isn't that "%c" exactly against the FDO spec? "Field codes must not be used inside a quoted argument, the result of field code expansion inside a quoted argument is undefined" (In reply to comment #4) > All KDE .desktop files have "%c" instead of %c, Docky should be able to deal > with it. What is the point of the quotes then? I ran into this problem originally because the templates in KDevelop used it. When trying to fix it, I used a message box to display the command line arguments, and the the name of my app was correctly be passed as one argument without the quotes around the %c, even though the name had a space in it. Right, so we have the have the arguments "The desktop file violates the freedesktop spec" and "It's being done like that everywhere in KDE" for and against changing it, respectively. @Michael: I guess it's better to discuss this on kde-core-devel, rather than in a Dolphin bug report. Maybe someone on the mailing list can tell you why the quotes are there. Depending on the outcome of the discussion, all desktop files (and not only Dolphin's) might have to be changed. As agreed on kde-core-devel list, all .desktop files from KDE are currently being corrected to not have quotes around %c. If you still see a particular desktop file wrong in the 4.11 release, please report it to the authors of the respective application. |