| Summary: | Remove superfluous .protocol files from source tree once we depend on kdelibs 4.9.3+ | ||
|---|---|---|---|
| Product: | [Applications] konversation | Reporter: | Bernhard Scheirle <bernhard+kde> |
| Component: | general | Assignee: | Konversation Developers <konversation-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | argonel, faure, hein |
| Priority: | LO | ||
| Version: | 1.5-rc1 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| URL: | irc://freenode.net/SomeChannel | ||
| Latest Commit: | Version Fixed In: | 1.7 | |
| Sentry Crash Report: | |||
|
Description
Bernhard Scheirle
2013-04-17 16:02:41 UTC
Can you see what happens when you run "konversation irc://freenode.net/SomeChannel" in a terminal? To cut the browser out of the loop as a possible error source. Ok, with the direct command it works. So this is a rekonq/konqueror bug? I'm not sure what's causing it so far, but I can reproduce it here. The *.protocol files Konversation installs to register itself for irc:// and other URL protocols haven't changed in many years however, and still look correct to me. I'm not sure why it's no longer working. Adding David Faure to the CC list, who is the expert for all things Konqueror and associations in general. Sounds like a missing %u in the Exec line of the .protocol or .desktop file, then. Note: installing irc.protocol is the old way (which should still work, but not if some apps use the new way). Does konversation's desktop have the mimetype x-scheme-handler/irc ? That's the new way. (freedesktop-compatible) The .protocol does "exec=konversation %u", yep. And the .desktop file contains "MimeType=x-scheme-handler/irc;x-scheme-handler/ircs;". And yet "konversation <url>" in the terminal works, but the same URL from the Konqueror address bar, or an embedded Link in KHTML, only raises the window .. Yes but you missed the important bit: konversation.desktop doesn't have %u on its Exec line. So kdelibs thinks this app doesn't support urls, and tries to download the url to a local file before calling the app. Add %u to konversation.desktop's exec line, and the bug will go away. It's not a problem for the case where the app is launched without a URL: the %u will simply be expanded to nothing. Also note that you can probably get rid of the .protocol file nowadays (depends on which old kdelibs you want to support). I can confirm that after adding "%u" to the desktop file, irc links behave as expected. And I guess the reason it used to work before is because it used to use the .protocol files instead. David, what's the lowest version of kdelibs supporting the new scheme? Git commit 8d69441eca6ea3e0818634af51c75a39658e16a2 by Eike Hein. Committed on 18/04/2013 at 19:37. Pushed by hein into branch '1.4'. Let kdelibs know we support URLs. M +1 -1 data/konversation.desktop http://commits.kde.org/konversation/8d69441eca6ea3e0818634af51c75a39658e16a2 I should have guessed the question would come up rather than lazily hoping it wouldn't :) a8c6a38c4a6b78a9d78ba014b2a5e8a03f6387e7 is in KDE 4.5 and following. Ah, but until 4.9.3, a .protocol file from another irc app would have precedence over a .desktop file x-scheme-handler. I fixed that in 7404764264e7dbe5a69afcbc2cc2a26d43cd3a7f OK, then I'll think we'll keep the .protocol files around until we depend on 4.9. Thanks David. Eike, what is the status of comment #13? Thanks for the reminder, I'll take care of removing them. Git commit c2d50532ab328340a797475403e37b66ca562987 by Eike Hein. Committed on 17/05/2015 at 23:42. Pushed by hein into branch 'master'. Remove .protocol files. KF5 always gives precedence to x-scheme-handler. D +0 -11 data/konvirc.protocol D +0 -11 data/konvirc6.protocol D +0 -11 data/konvircs.protocol http://commits.kde.org/konversation/c2d50532ab328340a797475403e37b66ca562987 |