Bug 318494

Summary:	Keyboard shortcuts, Make brush color darker/Lighter, unresponsive in Select tools other than rectangle & ellipse
Product:	[Applications] krita	Reporter:	David Gowers <finticemo>
Component:	Usability	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ghevan, sven.langkamp
Priority:	NOR
Version:	2.6.3
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/2d3edf10b2d5dea0825b82ccf54b156a0370f0d5	Version Fixed In:
Sentry Crash Report:

Description David Gowers 2013-04-17 08:52:10 UTC

Though following up a selection with a fill is a common operation, only two of the selection tools allow the color brightness adjustment hotkeys to work.
These are the Rectangle and Ellipse Select tools.

Tools which do not respond to the hotkeys include Select by Brush, Polygon, Outline, Contiguous Area, Similar Colors, and Path.

Ironically, the 'Fill with Background/Foreground/Pattern' keyboard shortcuts work okay for all of the selection tools.

Reproducible: Always

Steps to Reproduce:
1. Activate any of the listed 'unresponsive' selection tools
2. Make a selection (or not)
3. Attempt to activate either the 'Brighter FGcolor' or 'Darker FGcolor' shortcuts.

Actual Results:  
Nothing happens; The FGcolor remains the same.

Expected Results:  
The FGcolor changes accordingly

Keyboard shortcuts for adjusting FGcolor brightness are changed from their default K/L to keypad End/Home.
They operate as expected when using text, brush, multibrush, bucketfill, gradient fill, and all shape drawing tools

Comment 1 vanyossi 2013-04-19 18:26:35 UTC

Hi, Thanks for your report.

I can confirm this bug in Krita 2.7 alpha.

The shortcuts:
make brush color darker (K)
Make brush color lighter (L)

Become unresponsive when any of the following selection tool methods are selected.
Select by Brush, Select an area by its Outline, Select a Contiguous Area of colors, Select Similar Colors, and Select and area of the image with Path.

In my version shortcuts does work using "Select a Polygonal region"

Comment 2 Sven Langkamp 2013-09-27 15:41:38 UTC

I think we could move the action from the tool to the view (or some plugin). Should be useful globally.

Comment 3 Sven Langkamp 2013-09-27 21:19:05 UTC

Git commit 2d3edf10b2d5dea0825b82ccf54b156a0370f0d5 by Sven Langkamp.
Committed on 27/09/2013 at 21:17.
Pushed by langkamp into branch 'master'.

move color darkness and opacity controls to a new canvas controls manager, making them available globally

M  +1    -0    krita/ui/CMakeLists.txt
A  +113  -0    krita/ui/kis_canvas_controls_manager.cpp     [License: GPL (v2+)]
A  +52   -0    krita/ui/kis_canvas_controls_manager.h     [License: GPL (v2+)]
M  +6    -0    krita/ui/kis_view2.cpp
M  +0    -85   krita/ui/tool/kis_tool_paint.cc
M  +0    -11   krita/ui/tool/kis_tool_paint.h

http://commits.kde.org/calligra/2d3edf10b2d5dea0825b82ccf54b156a0370f0d5