| Summary: | Seam with Sharpen and Blur filters. | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Paul Geraskin <paulgeraskin> |
| Component: | Filters | Assignee: | Sahil <nagpal.sahil01> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | halla, nagpal.sahil01, reptillia39 |
| Priority: | NOR | ||
| Version: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | All | ||
| Latest Commit: | http://commits.kde.org/calligra/613079f33106124885323024c0be13f55ef776d2 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Seams on Sharpen Filter | ||
|
Description
Paul Geraskin
2013-04-16 14:59:25 UTC
Interesting... Yes, I can confirm. It must be something about the way we treat the edges of an image. Git commit 9f81cdd392a723c5fbebb7a12f01030cbe4b5cce by Dmitry Kazakov. Committed on 14/01/2014 at 19:24. Pushed by dkazakov into branch 'krita-testing-kazakov'. Fixed FFTW convolution worker to work properly in wraparound mode It had at least two problems: 1) Some memory offset problems causing random pixels accessed 2) Wrapped line iterators working incorrectly when the access rect was larger than the wrap rect. The rect iterator still has this problem, but at least tells the user that the result is undefined. M +10 -21 krita/image/kis_convolution_painter.cc M +3 -6 krita/image/kis_convolution_painter.h M +230 -201 krita/image/kis_convolution_worker_fft.h M +6 -0 krita/image/kis_iterator_ng.h M +4 -5 krita/image/kis_selection_filters.cpp M +27 -7 krita/image/kis_wrapped_hline_iterator.h M +40 -13 krita/image/kis_wrapped_line_iterator_base.h M +7 -15 krita/image/kis_wrapped_rect.h M +23 -0 krita/image/kis_wrapped_rect_iterator.h M +25 -4 krita/image/kis_wrapped_vline_iterator.h A +- -- krita/image/tests/data/paint_device_test/wrapped_iterators_huge_hline_iterator_-6_-6_34_34.png A +- -- krita/image/tests/data/paint_device_test/wrapped_iterators_huge_vline_iterator_-6_-6_34_34.png M +103 -2 krita/image/tests/kis_paint_device_test.cpp M +3 -0 krita/image/tests/kis_paint_device_test.h M +23 -0 krita/image/tiles3/kis_hline_iterator.cpp M +5 -1 krita/image/tiles3/kis_hline_iterator.h M +23 -0 krita/image/tiles3/kis_vline_iterator.cpp M +4 -0 krita/image/tiles3/kis_vline_iterator.h M +1 -0 krita/ui/tool/strokes/kis_filter_stroke_strategy.cpp http://commits.kde.org/calligra/9f81cdd392a723c5fbebb7a12f01030cbe4b5cce Git commit 613079f33106124885323024c0be13f55ef776d2 by Dmitry Kazakov. Committed on 14/01/2014 at 19:24. Pushed by dkazakov into branch 'calligra/2.8'. Fixed FFTW convolution worker to work properly in wraparound mode It had at least two problems: 1) Some memory offset problems causing random pixels accessed 2) Wrapped line iterators working incorrectly when the access rect was larger than the wrap rect. The rect iterator still has this problem, but at least tells the user that the result is undefined. M +10 -21 krita/image/kis_convolution_painter.cc M +3 -6 krita/image/kis_convolution_painter.h M +230 -201 krita/image/kis_convolution_worker_fft.h M +6 -0 krita/image/kis_iterator_ng.h M +4 -5 krita/image/kis_selection_filters.cpp M +27 -7 krita/image/kis_wrapped_hline_iterator.h M +40 -13 krita/image/kis_wrapped_line_iterator_base.h M +7 -15 krita/image/kis_wrapped_rect.h M +23 -0 krita/image/kis_wrapped_rect_iterator.h M +25 -4 krita/image/kis_wrapped_vline_iterator.h A +- -- krita/image/tests/data/paint_device_test/wrapped_iterators_huge_hline_iterator_-6_-6_34_34.png A +- -- krita/image/tests/data/paint_device_test/wrapped_iterators_huge_vline_iterator_-6_-6_34_34.png M +103 -2 krita/image/tests/kis_paint_device_test.cpp M +3 -0 krita/image/tests/kis_paint_device_test.h M +23 -0 krita/image/tiles3/kis_hline_iterator.cpp M +5 -1 krita/image/tiles3/kis_hline_iterator.h M +23 -0 krita/image/tiles3/kis_vline_iterator.cpp M +4 -0 krita/image/tiles3/kis_vline_iterator.h M +1 -0 krita/ui/tool/strokes/kis_filter_stroke_strategy.cpp http://commits.kde.org/calligra/613079f33106124885323024c0be13f55ef776d2 Created attachment 113791 [details]
Seams on Sharpen Filter
There is now seam back on Krita 4.2. It shows up on the sharpen sections only.
|