Bug 318180

Is this only for MUC? Could you test for normal 1-1 chats too.

Could you include the output of "mc-tool dump" between each step.

Created attachment 78920 [details]
Before hibernate

Created attachment 78921 [details]
after hibernate

Looks like it does not affects 1-1 chats.

Comment on attachment 78921 [details]
after hibernate


>     Account: gabble/jabber/pavel_5fn_40jabber_2eru0
>Display Name: pavel_n@jabber.ru
>  Normalized: pavel_n@jabber.ru
>     Enabled: enabled
>        Icon: im-jabber
>    Connects: automatically
>    Nickname: ambush
>     Service: jabber
>
>Presences:
>   Automatic: available (2) ""
>     Current: available (2) ""
>   Requested: available (2) ""
>    Changing: no
>
>      (string) resource = kde-telepathy
>      (string) account = pavel_n@jabber.ru

Confirming, can be reproduced with simply going offline and back online; then my nickname in a group chat is my "Display name" instead of "Nickname"

     Account: gabble/jabber/mck182_5f735374638_40kdetalk_2enet1
Display Name: mck182_735374638
  Normalized: mck182_735374638@kdetalk.net
     Enabled: enabled
        Icon: im-jabber
    Connects: only when requested
    Nickname: McK182__
     Service: kde-talk

I've found the cause of this bug.

When we reconnect, we immediately open channels to all the open chats. Gabble however does not have all the contact info yet, it connects us to the group chat while still processing the contact/account data. In the meantime, text-ui asks for contact data and Gabble simply passes whatever it has.

It's strange that when Gabble finishes processing the contact data, it's not updated in the channel, so that might be an upstream bug. Possible workaround on our side is to delay the channel recreation a bit (2-3 secs should be enough).

Did you report this upstream?

Any update on this?

It is still here... Telepathy, looks like nobody cares of it.

Yes, sadly the KDE Telepathy team is now just one man and all his time was spent on porting to kf5/qt5 and to kaccounts.

That said, are you able to test patches?

Yep, I can test them, but I don't experienced in C/C++

Created attachment 92078 [details]
Patch

Ok, please try the attached patch against master branch and report back.

Thanks.

Any reports on this patch? Looks like nobody cares of it.

Pavel, if you can provide the information requested in comment #13, please add it.

Created attachment 92659 [details]
attachment-15723-0.html

Sorry, I look into bugs mails not so often. I'll try to patch it today or
tomorrow.

On Sat, May 16, 2015 at 9:28 PM Christoph Feck <cfeck@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=318180
>
> --- Comment #15 from Christoph Feck <cfeck@kde.org> ---
> Pavel, if you can provide the information requested in comment #13, please
> add
> it.
>
> --
> You are receiving this mail because:
> You reported the bug.
>

Pavel, any update?

Hello,
Just tested your patch. Looks like this bug was fixed.
Thank you.

Sorry, it was Martin's patch.

This is not fixed, the patch is not pushed in yet, I was waiting all that time for you to report back.

So I assume it did fix your issue?

Hello Martin!
Sorry for that.
Your patch works great. I tell it in comment #18. 

Thank you!

Right, overlooked that comment, my bad.

Pushing...

Git commit 92f773a6ec92e97595b5173cc8ca039d3bde998d by Martin Klapetek.
Committed on 04/08/2015 at 15:22.
Pushed by mklapetek into branch 'Applications/15.08'.

Delay reconnecting to previously opened channels

This mostly works around a gabble bug which returns incomplete data when
reopening a channel immediately after gabble connects
FIXED-IN: 15.08.0

M  +18   -10   app/chat-tab.cpp
M  +1    -0    app/chat-tab.h

http://commits.kde.org/telepathy-text-ui/92f773a6ec92e97595b5173cc8ca039d3bde998d