Bug 317984

Summary: Conflict when setting close tab shortcut to "escape".
Product: [Unmaintained] telepathy Reporter: David Edmundson <kde>
Component: text-uiAssignee: Telepathy Bugs <kde-telepathy-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: git-latest   
Target Milestone: Future   
Platform: Other   
OS: Linux   
Latest Commit: http://commits.kde.org/telepathy-text-ui/b287d8ee3a06f894169956ef14692f6c368558ea Version Fixed/Implemented In: 0.6.1
Sentry Crash Report:

Description David Edmundson 2013-04-07 17:27:38 UTC 
[18:15] <jtalk> In my ktp-text-ui I assigned Esc as "close tab" action. it works, but when search toolbar is shown, it does not catch Esc as 'close toolbar' shortcut -- it closes tab. Generally, it's alright, but expected behaviour is closing search bar first. 

ChatWidget::keyPressEvent() probably needs an e->accept();
Comment 1 Roman 2013-04-07 20:34:50 UTC 
Git commit b287d8ee3a06f894169956ef14692f6c368558ea by Roman Nazarenko.
Committed on 07/04/2013 at 22:28.
Pushed by romann into branch 'kde-telepathy-0.6'.

Pressing Escape key when search bar is active now hides search bar even if Escape key is assigned to shortcut.
Reviewed-by: David Edmundson

M  +14   -0    lib/chat-search-bar.cpp
M  +3    -0    lib/chat-search-bar.h
M  +0    -5    lib/chat-widget.cpp

http://commits.kde.org/telepathy-text-ui/b287d8ee3a06f894169956ef14692f6c368558ea