Summary: | "Rename ..." in PHP | ||
---|---|---|---|
Product: | [Applications] kdevelop | Reporter: | Mister Ypsilon <mrypsilons> |
Component: | Language Support: PHP | Assignee: | kdevelop-bugs-null |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | laurentiusilviu, mrypsilons |
Priority: | NOR | ||
Version: | git master | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kdev-php/f68154391a30139a8763c09fe1d103ab13565479 | Version Fixed In: | 5.5.0 |
Description
Mister Ypsilon
2013-04-05 12:32:59 UTC
Confirmed. Just doesn't work here. You actually get the 'Rename ...' popup, but after accepting it nothing happens. *** Bug 392833 has been marked as a duplicate of this bug. *** Git commit f68154391a30139a8763c09fe1d103ab13565479 by Heinz Wiesinger, on behalf of Hugues Mitonneau. Committed on 28/12/2019 at 09:24. Pushed by wiesinger into branch 'master'. Fix rename of a variable Summary: Renaming a variable doesn't work. This is because in `KDevelop::DocumentChangeSetPrivate::generateNewText`, `rangeText(change.m_range, textLines)` return the value `$oldname` and `change.m_oldText` has the value `oldname` This patch modify the parser to remove the "$" in the range of variable identifiers. As a result, we can now rename a variable, but as a side effect, the "$" is no more highlighted with the variable (the "$" are always blue, and do not take color of the variable) {F7788333} {F7788334} {F7788335} Test Plan: Right-click on a variable Select "Rename xxx..." Choose a new name and click "Rename" All the occurrences of the variable must be renamed FIXED-IN: 5.5.0 Reviewers: pprkut Reviewed By: pprkut Subscribers: pprkut, kdevelop-devel Tags: #kdevelop Differential Revision: https://phabricator.kde.org/D25587 M +98 -0 codegen/refactoring.cpp M +17 -0 codegen/refactoring.h https://commits.kde.org/kdev-php/f68154391a30139a8763c09fe1d103ab13565479 |