Bug 317835

Summary:	Little problem of blocs colors
Product:	[Applications] kalzium	Reporter:	Tobias Bora <tobias.bora>
Component:	general	Assignee:	Kalzium Developers <kalzium>
Status:	RESOLVED FIXED
Severity:	minor	CC:	etienne.rebetez, lueck
Priority:	NOR
Version First Reported In:	2.4.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/kalzium/4ce2cd2183672dbfce429c57a4ce91f781651987	Version Fixed/Implemented In:
Sentry Crash Report:

Description Tobias Bora 2013-04-04 17:18:49 UTC

Hello,
First thanks a lot for your great program, I've only a little problem to report : when we choose in "color model" the model "blocs", then He (Helium) is colored in green (bloc p) instead of purple (bloc s). It's not very important, but not very hard to change I think.

Thanks.

Reproducible: Always

Steps to Reproduce:
1. In the main view, choose Color model/bloc
2. Helium is colored in green (bloc p) instead of purple (bloc s)

Comment 1 Burkhard Lück 2013-04-05 06:22:50 UTC

patch to display He with the color of block s:

$ git diff
diff --git a/libscience/data/elements.xml b/libscience/data/elements.xml
index e8ab22e..22470a1 100644
--- a/libscience/data/elements.xml
+++ b/libscience/data/elements.xml
@@ -75,7 +75,7 @@
     <array title="color" dictRef="bo:elementColor" size="3" dataType="xsd:float">0.85 1.00 1.00</array>
     <scalar dataType="xsd:float" dictRef="bo:boilingpoint"  units="siUnits:kelvin">4.216</scalar>
     <scalar dataType="xsd:float" dictRef="bo:meltingpoint"  units="siUnits:kelvin">0.95</scalar>
-    <scalar dataType="xsd:string" dictRef="bo:periodTableBlock">p</scalar>
+    <scalar dataType="xsd:string" dictRef="bo:periodTableBlock">s</scalar>
     <array dataType="xsd:string" delimiter="," size="2" dictRef="bo:discoveryCountry">se,uk</array>
     <scalar dataType="xsd:date" dictRef="bo:discoveryDate">1895</scalar>
     <array dataType="xsd:string" delimiter=";" size="2" dictRef="bo:discoverers">P. J. Janssen;J. N. Lockyer</array>

Comment 2 Etienne 2013-04-07 19:54:39 UTC

Hi all

Tobias, you are right. Helium is in the s group. Thanks for noticing that. 

Lueck the fix works. Can you commit the change?

Etienne

Comment 3 Burkhard Lück 2013-04-08 07:05:03 UTC

Git commit 4ce2cd2183672dbfce429c57a4ce91f781651987 by Burkhard Lück.
Committed on 08/04/2013 at 09:04.
Pushed by lueck into branch 'master'.

change He to s-block

M  +1    -1    libscience/data/elements.xml

http://commits.kde.org/kalzium/4ce2cd2183672dbfce429c57a4ce91f781651987

Comment 4 Burkhard Lück 2013-04-08 07:08:22 UTC

Git commit acb028dcaaaced965f63195694b636ac67d4fc0a by Burkhard Lück.
Committed on 08/04/2013 at 09:04.
Pushed by lueck into branch 'KDE/4.10'.

change He to s-block
(cherry picked from commit 4ce2cd2183672dbfce429c57a4ce91f781651987)

M  +1    -1    libscience/data/elements.xml

http://commits.kde.org/kalzium/acb028dcaaaced965f63195694b636ac67d4fc0a