Summary: | Wrong date for Ching Ming Festival (HK holiday) | ||
---|---|---|---|
Product: | [Applications] kdepimlibs | Reporter: | aditsu <aditsu> |
Component: | kholidays | Assignee: | John Layt <jlayt> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kdepim-bugs, miklcct, pariahsoc |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kdepimlibs/af11cf34fb30997979561deadbe95fc3280bfb97 | Version Fixed In: | 4.10.3 |
Sentry Crash Report: |
Description
aditsu
2013-04-04 16:22:25 UTC
It's defined following this rule: : Ching Ming Festival 5 April or 4 April in leap years (or if that day is a Sunday, then the following day) Isn't that correct ? Glen, Michael, what do you think ? Ah, I didn't see https://bugs.kde.org/show_bug.cgi?id=254073#c12 However, the proposed change in comment 13 and 14 will make the holiday incorrect for years < 2013 Ching Ming Festival follows the Chinese Calendar, which most average Hong Kong people (like me) don't really understand. I remember that I was told when I was a kid that Ching Ming Festival is always Apr 4, 5 or 6 but I don't really know the rule behind. I think it might better be hard coded. Here's a link from Hong Kong Observatory conversion table between Gregorian and Chinese Calendar (1901-2100): http://www.hko.gov.hk/gts/time/conversion.htm I forgot to mention: In the conversion table a literal translation of "Ching Ming" is used, i.e. "Bright & Clear". (In reply to comment #4) > Ching Ming Festival follows the Chinese Calendar, which most average Hong > Kong people (like me) don't really understand. I remember that I was told > when I was a kid that Ching Ming Festival is always Apr 4, 5 or 6 but I > don't really know the rule behind. I think it might better be hard coded. > > Here's a link from Hong Kong Observatory conversion table between Gregorian > and Chinese Calendar (1901-2100): > http://www.hko.gov.hk/gts/time/conversion.htm Thanks. The files were updated Git commit af11cf34fb30997979561deadbe95fc3280bfb97 by Christophe Giboudeaux. Committed on 17/04/2013 at 22:21. Pushed by cgiboudeaux into branch 'master'. Hardcode the Ching Ming Festival date FIXED-IN: 4.10.3 M +13 -12 kholidays/holidays/plan2/holiday_hk_en-gb M +13 -12 kholidays/holidays/plan2/holiday_hk_zh-cn http://commits.kde.org/kdepimlibs/af11cf34fb30997979561deadbe95fc3280bfb97 |