Summary: | KML editor panel (dock widget) | ||
---|---|---|---|
Product: | [Applications] marble | Reporter: | Dennis Nienhüser <nienhueser> |
Component: | general | Assignee: | Adrian Draghici <draghici.adrian.b> |
Status: | RESOLVED FIXED | ||
Severity: | task | CC: | aitashish173, shentey |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/marble/37977619162f91285b7862ac8dab5578d229f6e2 | Version Fixed In: | |
Attachments: | KML Editor Dock Widget replacing the previous toolbar used to display the actions provided by the annotate plugin |
Description
Dennis Nienhüser
2013-04-03 17:28:32 UTC
Created attachment 78909 [details]
KML Editor Dock Widget replacing the previous toolbar used to display the actions provided by the annotate plugin
I wonder if RenderPlugins should really depend on QWidget. I could well imagine that QWidgets are not available on every platform Qt 5.x will support, so this dependency could hit us hard when targeting these platforms. A quick'n'dirty fix would probably be to introduce an interface similar to the Marble::DialogConfigurationInterface. Git commit 37977619162f91285b7862ac8dab5578d229f6e2 by Dennis Nienhüser, on behalf of Adrian Draghici. Committed on 16/04/2013 at 20:59. Pushed by nienhueser into branch 'master'. KML Editor Dock Widget REVIEW: 110019 M +18 -0 src/QtMainWindow.cpp M +1 -0 src/QtMainWindow.h M +1 -1 src/lib/BranchFilterProxyModel.h M +5 -0 src/lib/RenderPlugin.cpp M +12 -0 src/lib/RenderPlugin.h M +131 -100 src/plugins/render/annotate/AnnotatePlugin.cpp M +6 -1 src/plugins/render/annotate/AnnotatePlugin.h http://commits.kde.org/marble/37977619162f91285b7862ac8dab5578d229f6e2 (In reply to comment #2) > I wonder if RenderPlugins should really depend on QWidget. I could well > imagine that QWidgets are not available on every platform Qt 5.x will > support, so this dependency could hit us hard when targeting these > platforms. A quick'n'dirty fix would probably be to introduce an interface > similar to the Marble::DialogConfigurationInterface. Currently QDockWidget is only introduced as a forward declaration in RenderPlugin.h. Not using things from QtGui is too much planning ahead in my opinion and too restrictive. If we ever run into the problem of Qt classes missing on a target platform (Qt is platform independent after all) and Qt guys haven't thought of a solution ahead, we can still adjust things. |