Bug 317712

Summary: does not find file to be attached if more than one consecutive space is in its name
Product: [Applications] kmail2 Reporter: Wolfgang Rohdewald <wolfgang>
Component: composerAssignee: kdepim bugs <pim-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: montel, wolfgang
Priority: NOR    
Version First Reported In: 4.10.1   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: http://commits.kde.org/kdelibs/80099c878a2d60ead7cb7bbbfab89e1eb5782dad Version Fixed In: 4.10.5
Sentry Crash Report:

Description Wolfgang Rohdewald 2013-04-02 07:09:54 UTC 
this happens only when attaching multiple files together. If one of the files is named "A  B" with two spaces between A and B, I am getting an error message

Die Datei oder der Ordner /home/wr/Dokumente/G/ggz/done/A%20 B existiert nicht.

Please note that only the first space has been encoded. And of course the error message should not show spaces in their encoded form.

Reproducible: Always
Comment 1 Laurent Montel 2013-04-02 07:18:49 UTC 
I confirm it.
Will fix it soon.
Comment 2 Laurent Montel 2013-04-02 08:03:17 UTC 
it's not a kmail bug it's a kdelibs bug.
Don't know why there is this problem.
Will investigate
Comment 3 David Faure 2013-06-07 13:01:42 UTC 
Git commit f54ca51c0a47811054ace6d208c6081ebdb363aa by David Faure.
Committed on 03/06/2013 at 14:21.
Pushed by dfaure into branch 'KDE/4.10'.

Fix bug in KUrl::relativeUrl: it wasn't encoding the path when creating the URL.

This answers my own question from a long time ago in the code...

M  +2    -1    kdecore/io/kurl.cpp
M  +4    -0    kdecore/tests/kurltest.cpp

http://commits.kde.org/kdelibs/f54ca51c0a47811054ace6d208c6081ebdb363aa
Comment 4 David Faure 2013-06-07 13:01:42 UTC 
Git commit 80099c878a2d60ead7cb7bbbfab89e1eb5782dad by David Faure.
Committed on 07/06/2013 at 15:03.
Pushed by dfaure into branch 'KDE/4.10'.

Fix misuse of KUrl::relativeUrl, which returns relative urls (duh).

Not paths. So this was leading to double-escaping, especially after fixing
KUrl::relativeUrl to actually escape as it's supposed to do.
FIXED-IN: 4.10.5

M  +21   -3    kfile/kfilewidget.cpp

http://commits.kde.org/kdelibs/80099c878a2d60ead7cb7bbbfab89e1eb5782dad
Comment 5 Wolfgang Rohdewald 2013-10-28 10:52:23 UTC 
KMail 4.11.2 still has this bug.
Comment 6 Wolfgang Rohdewald 2014-04-10 09:03:56 UTC 
works with 4.12.97