| Summary: | CSV exporter doesn't properly escape values with the delimiter | ||
|---|---|---|---|
| Product: | [Applications] tellico | Reporter: | Robby Stephenson <robby> |
| Component: | general | Assignee: | Robby Stephenson <robby> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 2.3.7 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/tellico/4a969303c9a28afa061afc2a5861c11951576ff7 | Version Fixed In: | 2.3.8 |
| Sentry Crash Report: | |||
|
Description
Robby Stephenson
2013-03-28 02:53:45 UTC
Git commit 4a969303c9a28afa061afc2a5861c11951576ff7 by Robby Stephenson. Committed on 28/03/2013 at 04:52. Pushed by rstephenson into branch '2.3'. Fix the CSV export to properly escape values with delimiter An old commit accidently removed the escapeText() call from one of the text export sections. As a result, values that include the delimiter (usually a comma) were not enclosed in double quotation marks. Add a unit test, as well. FIXED-IN: 2.3.8 M +4 -0 ChangeLog M +3 -3 src/tests/CMakeLists.txt M +21 -5 src/tests/csvtest.cpp M +1 -1 src/tests/csvtest.h M +7 -4 src/translators/csvexporter.cpp M +2 -1 src/translators/csvexporter.h http://commits.kde.org/tellico/4a969303c9a28afa061afc2a5861c11951576ff7 |