Bug 317158

Summary:	Setting up new AppSocket/HP Jet Direct printer are deactivated by default
Product:	[Frameworks and Libraries] print-manager	Reporter:	Mathias Dietrich <dietrichmathias>
Component:	general	Assignee:	Daniel Nicoletti <dantti12>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/print-manager/b73b2cd986d8bbce9ace1a8cbd0fbf892312e4f6	Version Fixed In:
Sentry Crash Report:

Description Mathias Dietrich 2013-03-21 20:23:47 UTC

When i set up a new AppSocket/HP Jet Direct printer using print-manager the printer always stands on hold and i have to reenable it via "open printer queue" -> "resume printer"

Reproducible: Always

Steps to Reproduce:
1. Create a new printer Appsocket printer
Actual Results:  
Nothing gets printed until I resume the printer in the print queue

Expected Results:  
The printer is already enabled so that the user can print directly

KDE Version 4.10.1

Comment 1 Daniel Nicoletti 2013-04-27 01:07:59 UTC

Git commit b2ba0e6fe602bfc1bd9a00793e679fbf1092f635 by Daniel Nicoletti.
Committed on 27/04/2013 at 03:06.
Pushed by dantti into branch 'KDE/4.10'.

Since CUPS sometimes add disabled printer, we make sure we
enable them after added

M  +3    -0    add-printer/AddPrinterAssistant.cpp
M  +33   -0    add-printer/PageAddPrinter.cpp
M  +3    -0    add-printer/PageAddPrinter.h

http://commits.kde.org/print-manager/b2ba0e6fe602bfc1bd9a00793e679fbf1092f635

Comment 2 Daniel Nicoletti 2013-05-21 22:45:46 UTC

Git commit b73b2cd986d8bbce9ace1a8cbd0fbf892312e4f6 by Daniel Nicoletti.
Committed on 22/05/2013 at 00:42.
Pushed by dantti into branch 'KDE/4.10'.

Properly add a printer which accepts jobs and is idle by using the right parameters,
this mostly reverts b2ba0e6fe602bfc1bd9a00793e679fbf1092f635 but as it
also included a fix to finish button I'm going to keep the commit

M  +2    -35   add-printer/PageAddPrinter.cpp
M  +0    -3    add-printer/PageAddPrinter.h

http://commits.kde.org/print-manager/b73b2cd986d8bbce9ace1a8cbd0fbf892312e4f6