Summary: | LibKGAPI ignores proxy settings | ||
---|---|---|---|
Product: | [Frameworks and Libraries] libkgapi | Reporter: | Luiz Angelo De Luca <luizluca> |
Component: | General | Assignee: | Daniel Vrátil <dvratil> |
Status: | CLOSED FIXED | ||
Severity: | normal | CC: | kdepim-bugs, pierre.sauter |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/akonadi-google/296c5b852b5d2afc6df38c87c41a5e29d7f4cb5a | Version Fixed In: | 2.0 |
Sentry Crash Report: | |||
Attachments: |
patch fixing this bug, tested on Kubuntu 14.04
Patch for current trunk in extragear |
Description
Luiz Angelo De Luca
2013-03-18 17:51:08 UTC
Can you please specify which version of LibKGAPI you use? I'm using OpenSUSE buildservice packages and my libkgapi package is libkgapi0-0.4.4-12.1.x86_64 Git commit 296c5b852b5d2afc6df38c87c41a5e29d7f4cb5a by Dan Vrátil. Committed on 14/05/2013 at 16:30. Pushed by dvratil into branch 'master'. Use KWebView instead QWebView to support KDE proxy settings FIXED-IN: 2.0 M +1 -1 common/authwidget_p.inc.cpp M +1 -0 libkgapi/ui/authwidget_p.cpp M +1 -0 libkgapi2/ui/authwidget_p.cpp http://commits.kde.org/akonadi-google/296c5b852b5d2afc6df38c87c41a5e29d7f4cb5a In Kubuntu 14.04 this bug is still present. The attached patch is necessary to completely fix the problem. QWebView::setUrl is a non-virtual function. Without declaring webview as a proper KWebView reference, the wrong (i.e. not honouring KDE proxy settings) QWebView method gets called on dispatch. Created attachment 92283 [details]
patch fixing this bug, tested on Kubuntu 14.04
Created attachment 92284 [details]
Patch for current trunk in extragear
The other patch was against an older version, since rev bd008477622b873fad7c6b77c33dad6e2a47ca8b this one is correct.
fwiw, the last patch was applied to both the stable and master branches |