Bug 316620

Summary: html export doesn't build
Product: [Applications] digikam Reporter: nucleo <nucleo>
Component: Plugin-Generic-HTMLGalleryAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, kevin.kofler, rdieter
Priority: NOR    
Version: 3.1.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: http://commits.kde.org/kipi-plugins/006b3f415f6636508d95160b0d22c10da5c32717 Version Fixed In: 3.2.0
Sentry Crash Report:
Attachments: patch based on comment 2

Description nucleo 2013-03-12 21:09:16 UTC 
htmlexport kipi-plugin don't builds

Reproducible: Always

Actual Results:  
This commit makes impossible compilation of htmlexport even if libxml2 and libxslt reported as found
http://quickgit.kde.org/?p=kipi-plugins.git&a=commitdiff&h=b5514a7616b3a5b25f678af13fa2573ba1ea3b0f&o=plain


Reverting this patch makes possible htmlexport compilation.
Comment 1 Rex Dieter 2013-03-12 21:59:30 UTC 
confirmed, htmlexport plugin doesn't get built
Comment 2 Kevin Kofler 2013-03-12 22:10:14 UTC 
These 3 lines:
+    if (NOT LIBXSLT_EXSLT_LIBRARIES AND NOT LIBXSLT_LIBRARIES)
+        set(LIBXSLT_EXSLT_LIBRARIES ${LIBXSLT_LIBRARIES})
+    endif (NOT LIBXSLT_EXSLT_LIBRARIES AND NOT LIBXSLT_LIBRARIES)
in the patch are wrong:
1. There's a typo or thinko (3 times), it should say LIBEXSLT_LIBRARIES everywhere in these 3 lines, not LIBXSLT_LIBRARIES.
2. There should be no NOT in front of LIBEXSLT_LIBRARIES in the if condition.

In other words, the above 3 lines should read:
+    if (NOT LIBXSLT_EXSLT_LIBRARIES AND LIBEXSLT_LIBRARIES)
+        set(LIBXSLT_EXSLT_LIBRARIES ${LIBEXSLT_LIBRARIES})
+    endif (NOT LIBXSLT_EXSLT_LIBRARIES AND LIBEXSLT_LIBRARIES)
Comment 3 nucleo 2013-03-12 22:28:16 UTC 
htmlexport builds with changes from Comment 2.
Comment 4 caulier.gilles 2013-03-12 22:31:10 UTC 
Sound like we only just wrap this cmake code to IF(APPLE) statements

If this patch is not applied, it don't compile under Macports.

Gilles Caulier
Comment 5 Kevin Kofler 2013-03-12 23:06:45 UTC 
No IF(APPLE) needed. Just fix the errors in the patch as per comment #2 and it will work everywhere.
Comment 6 nucleo 2013-03-13 13:44:27 UTC 
Created attachment 78013 [details]
patch based on comment 2
Comment 7 caulier.gilles 2013-03-13 14:46:51 UTC 
Git commit 006b3f415f6636508d95160b0d22c10da5c32717 by Gilles Caulier.
Committed on 13/03/2013 at 17:09.
Pushed by cgilles into branch 'master'.

apply patch #78013 from Nucleo

M  +3    -3    CMakeLists.txt

http://commits.kde.org/kipi-plugins/006b3f415f6636508d95160b0d22c10da5c32717