| Summary: | Crash when joining a chat room with no account selected | ||
|---|---|---|---|
| Product: | [Unmaintained] telepathy | Reporter: | David Edmundson <kde> |
| Component: | common-internals | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mklapetek |
| Priority: | NOR | ||
| Version: | git-latest | ||
| Target Milestone: | 0.6.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/telepathy-common-internals/2f2acee2b2b9a6281654042a3c75325c41ede44e | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
David Edmundson
2013-03-10 21:49:44 UTC
How about also disabling the OK button when no account is selected? OR showing a kmessagewidget "Select account first" when OK clicked and no account selected. agree we should disable it. + add a guard against crashing anyway. Git commit 2f2acee2b2b9a6281654042a3c75325c41ede44e by David Edmundson. Committed on 10/03/2013 at 23:58. Pushed by davidedmundson into branch 'master'. Fix crashing in join chat room dialog REVIEW: 109400 M +9 -1 KTp/Widgets/join-chat-room-dialog.cpp http://commits.kde.org/telepathy-common-internals/2f2acee2b2b9a6281654042a3c75325c41ede44e I've dealt with the crash, if you want to enabling/disabling the OK button please do. |