| Summary: | Log viewer should display "no logs" when opened with contact id and no logs present | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] telepathy | Reporter: | Martin Klapetek <mklapetek> |
| Component: | log-viewer | Assignee: | Daniel Vrátil <dvratil> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dvratil, kde |
| Priority: | NOR | ||
| Version: | git-latest | ||
| Target Milestone: | 0.7-beta | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/telepathy-text-ui/452b06f4896222bca38987280359b7a4cad02969 | Version Fixed In: | 0.7.0 |
|
Description
Martin Klapetek
2013-03-10 20:48:59 UTC
Agreed. Confirming. Is this still valid? Contact-list now doesn't let you open if there's no log. The sidebar only lists contacts with logs. Yes. You have other ways to open the log viewer with valid id and no logs. I would like to extend this to showing "No logs available for this day" message when you select a date with no logs. Git commit 452b06f4896222bca38987280359b7a4cad02969 by Dan Vrátil. Committed on 18/06/2013 at 18:27. Pushed by dvratil into branch 'master'. Show a message when no logs are available for given contact or day Shows a label saying "There are no logs for this day" or "There are no logs for this contact" when user selects a date without logs or starts logviewer with ID of a contact for which we have no logs. REVIEW: 111088 FIXED-IN: 0.7.0 M +4 -0 logviewer/entity-view.cpp M +4 -1 logviewer/entity-view.h M +6 -0 logviewer/log-viewer.cpp M +2 -0 logviewer/log-viewer.h M +35 -4 logviewer/message-view.cpp M +8 -0 logviewer/message-view.h http://commits.kde.org/telepathy-text-ui/452b06f4896222bca38987280359b7a4cad02969 |