| Summary: | Using the scroll wheel when Flip Switch is activated via a Screen Edge causes KWin to crash | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Mike Vaughn <mike.vaughn.83> |
| Component: | general | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | gridi_i |
| Priority: | NOR | Flags: | thomas.luebking:
ReviewRequest+
|
| Version: | 4.10.1 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| URL: | http://git.reviewboard.kde.org/r/109362/ | ||
| Latest Commit: | http://commits.kde.org/kde-workspace/c7a31381c037eb81033462ea4310c0a3e469193a | Version Fixed In: | 4.11 |
| Sentry Crash Report: | |||
|
Description
Mike Vaughn
2013-03-07 08:35:01 UTC
Why can flipswitch be activated through the screen edges in the first place? If at all, it should be possible to activate tabbox #n this way. Code crashes because there's no tabbox and w/o a tabbox using the wheel (or flipswitch) makes no sense at all. (In reply to comment #1) > Why can flipswitch be activated through the screen edges in the first place? because I'm an idiot? Thought it's a good idea to have a non-tabbox version of flipswitch which could be activated over screenedge. > If at all, it should be possible to activate tabbox #n this way. not a bad idea given that we have the non modal mode nowadays. Still tricky but with a fullscreen input window that could be possible. (In reply to comment #1) > Why can flipswitch be activated through the screen edges in the first place? > If at all, it should be possible to activate tabbox #n this way. > > Code crashes because there's no tabbox and w/o a tabbox using the wheel (or > flipswitch) makes no sense at all. Well, FWIW, it's possible to cycle through windows in Flip Switch using the scroll wheel when it's invoked via a keyboard shortcut. >(In reply to comment #2) > because I'm an idiot? ahh.. i wouldn't go so far. You *were* an idiot ;-P > Thought it's a good idea to have a non-tabbox version To do what =) > but with a fullscreen input window that could be possible. We could conditionally pre-pass events to the screenedges (this would also fix Michails trouble with his popup using script) (In reply to comment #3) > Well, FWIW, it's possible to cycle through windows in Flip Switch using the > scroll wheel when it's invoked via a keyboard shortcut. "kwin --replace &" don't do anything else, but invoke flipswitch by shortcut. try to wheel. -> same crash. (In reply to comment #5) > (In reply to comment #3) > > > Well, FWIW, it's possible to cycle through windows in Flip Switch using the > > scroll wheel when it's invoked via a keyboard shortcut. > > "kwin --replace &" > don't do anything else, but invoke flipswitch by shortcut. > try to wheel. > -> same crash. Ahh, so it does. Took me a while to see what you meant, as I was using the shortcut bound in the Task Switcher KCM (which didn't lead to the crash), rather than the one set in Flip Switch's actual settings. No, that /is/ the tabbox ;-) (In reply to comment #4) > We could conditionally pre-pass events to the screenedges (this would also Yes, works. RR tomorrow. Err... later ;-) Git commit c7a31381c037eb81033462ea4310c0a3e469193a by Thomas Lübking. Committed on 08/03/2013 at 20:17. Pushed by luebking into branch 'master'. general tabbox support for screenedges REVIEW: 109362 FIXED-IN: 4.11 M +0 -29 kwin/effects/flipswitch/flipswitch.cpp M +0 -4 kwin/effects/flipswitch/flipswitch.h M +0 -2 kwin/effects/flipswitch/flipswitch.kcfg M +10 -1 kwin/events.cpp M +23 -31 kwin/kcmkwin/kwinscreenedges/main.cpp M +2 -2 kwin/kcmkwin/kwinscreenedges/main.h M +42 -0 kwin/tabbox/tabbox.cpp M +3 -0 kwin/tabbox/tabbox.h http://commits.kde.org/kde-workspace/c7a31381c037eb81033462ea4310c0a3e469193a *** Bug 322682 has been marked as a duplicate of this bug. *** |