Bug 315866

Summary:	"Apply to group" setting of diminactive effect does not apply (kcfg mismatch)
Product:	[Plasma] kwin	Reporter:	Christopher Neufeld <kdebugs>
Component:	effects-various	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	metalbrick
Priority:	NOR	Flags:	thomas.luebking: ReviewRequest+
Version:	4.10.0
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
URL:	https://git.reviewboard.kde.org/r/112237/
Latest Commit:	http://commits.kde.org/kde-workspace/445453997f3d9b1014d60e2b695c6601398915ba	Version Fixed In:	4.11.1
Sentry Crash Report:

Description Christopher Neufeld 2013-02-27 19:16:59 UTC

When "dim inactive" is used, you can quickly locate the window that has focus.  If I have two emacs windows open, and one of them has focus, only that one is at full brightness, the other window is dim.  This does not apply to konsole windows.  If any konsole window has focus, all of them are at full brightness.

Reproducible: Always

Steps to Reproduce:
1. Enable the "dim inactive" effect
2. Open two or more konsole windows
3. Let one of the konsole windows obtain focus, and observe that all konsoles brighten
Actual Results:  
All konsole brighten and dim together.

Expected Results:  
Only one konsole should show up as bright.

This worked as expected in 4.8.0, but no longer works in 4.10.0

Comment 1 Thomas Lübking 2013-02-27 19:30:31 UTC

do you have "apply effect to groups" checked?

Unrelated sidenote: the value can no more be altered on git master (likely due to kcfg transition)

Comment 2 Christopher Neufeld 2013-02-27 19:32:10 UTC

No, "apply effect to groups" is not checked.  I also note that it cannot be checked in my build, which was from a git checkout against tag v4.10.0.

Comment 3 Thomas Lübking 2013-02-27 19:43:32 UTC

kreadconfig --file kwinrc --group Effect-DimInactive --key DimByGroup

If that prints "true" or nothing, there's your problem.
Call

kwriteconfig --file kwinrc --group Effect-DimInactive --key DimByGroup false
qdbus org.kde.kwin /KWin reconfigure
qdbus org.kde.kwin /KWin reconfigureEffect diminactive
qdbus org.kde.kwin /KWin reconfigureEffect kwin4_effect_diminactive

(i'm not sure which of the latter two is the required one)

Please update the bug in that regard.

Comment 4 Christopher Neufeld 2013-02-27 19:53:23 UTC

I ran the first command,  "kreadconfig --file kwinrc --group Effect-DimInactive --key DimByGroup",  it printed a blank line.  So, following the recipe above

$ kwriteconfig --file kwinrc --group Effect-DimInactive --key DimByGroup false
$ qdbus org.kde.kwin /KWin reconfigure

At this point, the expected behaviour returned.  I ran the last two commands but didn't observe any change.  This appears to have fixed the bug for me.

Note that when I installed 4.10.0, I deleted my .kde directory to get a fresh start on settings, so, while this technique works to solve the problem, it does seem to be something that happens on fresh installs.  The [Effect-DimInactive] record in the auto-generated kwinrc was absent.  The procedure described in comment #3 inserts the missing record and fixes the problem.

So, perhaps a better description of the bug would be that that record isn't created during a fresh install.

Comment 5 Martin Flöser 2013-02-27 20:03:34 UTC

> So, perhaps a better description of the bug would be that that record isn't created during a fresh install.

no everything is fine. The default for this value is "true", so the system functioned exactly as expected and advertised. Which renders the bug report as invalid

Comment 6 Thomas Lübking 2013-02-27 20:07:34 UTC

Still a bug ;-)

(In reply to comment #4)
> At this point, the expected behaviour returned.  
Thanks.

> Note that when I installed 4.10.0, I deleted my .kde directory to get a
> fresh start on settings,
meeehhh.... rather don't. If there's a problem, bisect and solve it. This way you drop _all_ your custom settings.

> So, perhaps a better description of the bug would be that that record isn't
> created during a fresh install.
No, that's not a bug. At least this is the default setting in the kcfg description.

Comment 7 Christopher Neufeld 2013-02-27 20:47:39 UTC

Note, however, that the problem appeared only on konsole windows.  My emacs windows were behaving correctly before I applied the fix in comment #3.

I remember this happening before, but I have been unable to find the original bug report.  At that time, the diagnosis was that the issue occurred with konsoles because, unlike most other processes, there is only one "konsole" job in the process table list even when there are multiple konsole windows.

Comment 8 Thomas Lübking 2013-02-27 20:49:51 UTC

(In reply to comment #7)
> unlike most other processes, there is only
> one "konsole" job in the process table list even when there are multiple
> konsole windows.
Yes, that's (ultimately) why they're considered "group".

Comment 9 metalbrick 2013-08-24 04:31:10 UTC

Similar problem with, though I just cannot use the feature of "Apply effect to groups".
Once I checked it and Apply, reopen the configure dialog, it just unchecked again.

Comment 10 Thomas Lübking 2013-08-25 15:04:13 UTC

Git commit 445453997f3d9b1014d60e2b695c6601398915ba by Thomas Lübking.
Committed on 24/08/2013 at 10:19.
Pushed by luebking into branch 'KDE/4.11'.

align GUI object name to kcfg name
FIXED-IN: 4.11.1
REVIEW: 112237

M  +2    -2    kwin/effects/diminactive/diminactive_config.ui

http://commits.kde.org/kde-workspace/445453997f3d9b1014d60e2b695c6601398915ba