Summary: | "First layer from clipboard" auto selects even after explicit unselect [JJ] | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | vanyossi <ghevan> |
Component: | Usability | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dimula73, halla, nagpal.sahil01, valerie_vk |
Priority: | NOR | Keywords: | junior-jobs |
Version: | git master (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/calligra/daa19d8f9843ee7451638abc13d54acdf693ace9 | Version Fixed In: | |
Attachments: |
First layer from clipboard" auto select problem fixed.
Solves the problem of changing height and width easily |
Description
vanyossi
2013-02-25 22:49:00 UTC
Thanks for your report. We can confirm it. It should be an easy fix, so I'll mark it as a Junior Job for now. Also, raising priority, since it's something that impacts the first impression of Krita. Created attachment 78540 [details]
First layer from clipboard" auto select problem fixed.
Looks good! Thanks -- I'll push the patch for you. (In reply to comment #4) > Looks good! Thanks -- I'll push the patch for you. Was this pushed? I see no commit message about that. Good point, I'll check with Sahil. He's got his own developer id now, he's keeping me real busy with his patches :-) It's fixed for me, just so you'd know. :D Thanks! Yeah, I pushed that. Forget my own head next. The behavior of the "First layer from clipboard" option is still quite weird: i) When changing the size of the image manually, typing is veeery slow: it looks like the clip is recreated of every valueChanged() signal or something. Even when the checkbox is off, but the clipboard contains an image. ii) Switching off/on the checkbox sometimes resets the values of the size textboxes, even when you typed them manually before. Sometimes it happens even more weirdly: 1) type width; 2) type height; 3) after accepting height, the width is somehow reset to the clip's width automatically. The second weirdness happens, when you do the following: 1) Type Width 2) Select entire Height field with mouse 3) Start typing Height without explicit deletion of the current contents In the result the Width is reset back to the clip's width. Created attachment 79719 [details]
Solves the problem of changing height and width easily
The patch also does a part of the work of Bug: 187300- Better visibility of the new image..
Git commit 0545a852342b581da0d9f5f28905edaec0f19372 by Boudewijn Rempt. Committed on 06/05/2013 at 14:19. Pushed by rempt into branch 'master'. Fix issues with width/height when creatign image from clipboard Patch by Sahil Nagpal M +16 -10 krita/ui/forms/wdgnewimage.ui M +20 -10 krita/ui/widgets/kis_custom_image_widget.cc M +1 -0 krita/ui/widgets/kis_custom_image_widget.h http://commits.kde.org/calligra/0545a852342b581da0d9f5f28905edaec0f19372 Git commit f62ba74f786bb72392fbba5822c10decc0e796f4 by Dmitry Kazakov, on behalf of Boudewijn Rempt. Committed on 06/05/2013 at 14:19. Pushed by dkazakov into branch 'calligra/2.7'. Fix issues with width/height when creatign image from clipboard Patch by Sahil Nagpal M +16 -10 krita/ui/forms/wdgnewimage.ui M +20 -10 krita/ui/widgets/kis_custom_image_widget.cc M +1 -0 krita/ui/widgets/kis_custom_image_widget.h http://commits.kde.org/calligra/f62ba74f786bb72392fbba5822c10decc0e796f4 Git commit daa19d8f9843ee7451638abc13d54acdf693ace9 by Siddharth Sharma, on behalf of Boudewijn Rempt. Committed on 06/05/2013 at 14:19. Pushed by siddharthsharma into branch 'krita-psd-plugin-siddharth'. Fix issues with width/height when creatign image from clipboard Patch by Sahil Nagpal M +16 -10 krita/ui/forms/wdgnewimage.ui M +20 -10 krita/ui/widgets/kis_custom_image_widget.cc M +1 -0 krita/ui/widgets/kis_custom_image_widget.h http://commits.kde.org/calligra/daa19d8f9843ee7451638abc13d54acdf693ace9 |