Bug 315720

Summary:	Gwenview does not update images after rotation
Product:	[Applications] gwenview	Reporter:	Volkan <volkangezer>
Component:	general	Assignee:	Gwenview Bugs <gwenview-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	agateau, benni, e.lex, JohnRCox, spaz16
Priority:	NOR
Version:	4.10.0
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/gwenview/5b541a0364a5c05716a07fb1a2e778a3ef0ad4bd	Version Fixed In:	4.10.4
Sentry Crash Report:

Description Volkan 2013-02-24 16:07:16 UTC

When viewing images in fullscreen mode (by double clicking) if we hover mouse at the top, we see right and left rotate buttons. Clicking on them rotates in the background, but does not show rotated image properly till we go next image and coming back (instead it just scales the image with rotated sizes).

Reproducible: Always

Steps to Reproduce:
1. Open an image using gwenview
2. Double click to enter full screen
3. Rotate image
Actual Results:  
It does not show the image rotated, just resizes it

Expected Results:  
It should rotate the image.

Comment 1 Volkan 2013-03-14 13:52:43 UTC

I just noticed that only thumbnails rotate till we press escape and click the same image again.

Comment 2 Benni Hill 2013-03-18 16:27:43 UTC

Hi Volkan,

I think this is a duplicate of bug 316845. (The image is only stretched and not rotated.)
If I'm wrong please reopen.

*** This bug has been marked as a duplicate of bug 316845 ***

Comment 3 Volkan 2013-03-18 22:43:12 UTC

(In reply to comment #2)
> Hi Volkan,
> 
> I think this is a duplicate of bug 316845. (The image is only stretched and
> not rotated.)
> If I'm wrong please reopen.
> 
> *** This bug has been marked as a duplicate of bug 316845 ***

Umm, actually no since this is valid only for Fullscreen and always reproducable :/

Comment 4 Benni Hill 2013-03-30 00:06:14 UTC

Ok, can you test if this occurs with variable screen resolutions?

Comment 5 Volkan 2013-03-30 14:32:27 UTC

(In reply to comment #4)
> Ok, can you test if this occurs with variable screen resolutions?

Yes, this occurs again. But the problem is only in 90-degree rotations. 180-deg seems OK.

Comment 6 JohnRCox@comcast.net 2013-04-24 19:40:22 UTC

The problem exists in gwenview-4.10.2 on my gentoo amd64 system. Symptoms are: rotations after the first result in the display not being rotated but resized to the rotated image size, resulting in a distortion. Saving the image results in a correctly rotated image on the screen.

Comment 7 Aurelien Gateau 2013-05-30 15:10:13 UTC

*** Bug 316845 has been marked as a duplicate of this bug. ***

Comment 8 Aurelien Gateau 2013-05-30 15:18:58 UTC

Can someone review this patch: https://git.reviewboard.kde.org/r/110730/ ?

Comment 9 alexander 2013-05-30 18:54:44 UTC

Thanks Aurelien, it seems to work for me.

Comment 10 Aurelien Gateau 2013-05-30 19:49:11 UTC

Git commit 5b541a0364a5c05716a07fb1a2e778a3ef0ad4bd by Aurélien Gâteau.
Committed on 30/05/2013 at 17:12.
Pushed by gateau into branch 'KDE/4.10'.

Work-around for failure to update images after rotation
REVIEW: 110730
FIXED-IN: 4.10.4

M  +5    -0    lib/imagescaler.cpp

http://commits.kde.org/gwenview/5b541a0364a5c05716a07fb1a2e778a3ef0ad4bd