| Summary: | Setting terminal title with newline character print unexpected newline to the terminal. | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Yichao Yu <yyc1992> |
| Component: | emulation | Assignee: | Konsole Bugs <konsole-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bansal.ashish096 |
| Priority: | NOR | ||
| Version First Reported In: | 2.10 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/konsole/d547d1d177bd0582df95a5d50dc3b37e0636748e | Version Fixed/Implemented In: | 18.08 |
| Sentry Crash Report: | |||
Oh I flipped the expected and actual result................ SHOULD BE: Actual Results: print "j j" Expected Results: print "jj" Anything between the \e]2; and the \a (007) should not be outputted to the screen. I think this bug has already been resolved as I am getting Expected Results! (In reply to Ashish Bansal from comment #3) > I think this bug has already been resolved as I am getting Expected Results! Oh, sorry I didn't read the second post !! Git commit d547d1d177bd0582df95a5d50dc3b37e0636748e by Kurt Hindenburg, on behalf of Ahmad Samir.
Committed on 24/05/2018 at 12:34.
Pushed by hindenburg into branch 'master'.
Ignore control characters in the text part of Xpe "ESC]" sequences
Summary:
Ignore control characters in the text part of Xpe (OSC, Operating System
Control) of the form "ESC]Pn;Pt\a" escape sequences; this matches what
XTerm docs say.
If userTitle is an empty string, set the window title to a blank space
when showWindowTitleOnTitleBar is enabled; basically if the user sets
the title to an empty string, leave it as-is.
FIXED-IN: 18.08
Test Plan:
- unset PROMPT_COMMAND, in case the shell is configured to set the
window title via that variable
- Make sure "Show window title on the title bar" is enabled
- Execute:
$ /usr/bin/echo -e 'j\e]2;\n\aj'
- The window title is changed to the tab title text; and the output
looks like this:
j
j
- Apply the diff, build, and try again, the window title should be
set to an empty string (really a blank space), and the output
should look like:
jj
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: konsole-devel, #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D13078
M +6 -3 src/MainWindow.cpp
M +6 -0 src/Vt102Emulation.cpp
https://commits.kde.org/konsole/d547d1d177bd0582df95a5d50dc3b37e0636748e
|
I set the terminal title according to my current command line, which sometimes include newline in it. In konsole, I always get several annoy blank lines with multi-line command (for loops etc.). The problem turns out to be the newline's (not any other characters) in the terminal title I set got unexpectedly echo back to the terminal. This doesn't happen in vte{2,3}, xterm, so should be a bug of konsole. Reproducible: Always Steps to Reproduce: 1. run command `env echo -e 'j\e]2;\n\aj'` in konsole (use `env echo` to avoid any shell-specific features of builtin echo's.) 2. 3. Actual Results: print "jj" Expected Results: print "j j"