Bug 315302

Summary: TimeAdjust is not shown in Application [patch]
Product: [Applications] digikam Reporter: Karol Slanina <karol.slanina>
Component: Plugin-Generic-TimeAdjustAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: caulier.gilles, smit.meh
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: http://commits.kde.org/kipi-plugins/7ce28b03dd7e579e58fa59f2b9ba0f56995283b2 Version Fixed In: 3.1.0
Sentry Crash Report:
Attachments: Patch enabling TimeAdjust in Gwenview

Description Karol Slanina 2013-02-17 01:46:17 UTC 
TimeAdjust has a dependency on KIPI feature "ImagesHasTime" although it doesn't have to. This prevents it from being shown in other applications than Digikam, for example in Gwenview.
It would perfectly make sense for TimeAdjust to be enabled in Gwenview, too; because it is not dependent on application-provided timestamps only. It can use and/or update any other timestamps such as selected metadata, filesystem etc.

Instead of declaring a dependency on ImagesHasTime, it is better to check if the current application supports it and if not, only the application timestamp related controls should be disabled (or made invisible). This means, the application timestamp should not be usable as the source and it shoud not be updateable.

I created a patch that makes exactly this change and the plugin just works in Digikam, as well as in Gwenview.

Reproducible: Always

Steps to Reproduce:
1. Start Gwenview
2. List plugins
3. Go to Images >
Actual Results:  
Adjust Time & Date plugin is not shown

Expected Results:  
The plugin should be shown, but with invisible options to use/update the nonexistent "Gwenview timestamp"
Comment 1 Karol Slanina 2013-02-17 02:00:10 UTC 
Created attachment 77377 [details]
Patch enabling TimeAdjust in Gwenview
Comment 2 caulier.gilles 2013-02-17 07:58:57 UTC 
Smit, 

this patch is for you...

Gilles
Comment 3 Smit Mehta 2013-02-22 09:54:50 UTC 
Git commit 7ce28b03dd7e579e58fa59f2b9ba0f56995283b2 by Smit Mehta.
Committed on 22/02/2013 at 10:53.
Pushed by smitmehta into branch 'master'.

Applied patch for making TimeAdjust plugin work in Gwenview as well.
Credits for patch : Karol Slanina

M  +0    -1    timeadjust/kipiplugin_timeadjust.desktop.cmake
M  +1    -0    timeadjust/plugin_timeadjust.cpp
M  +12   -3    timeadjust/settingswidget.cpp
M  +1    -0    timeadjust/settingswidget.h
M  +5    -0    timeadjust/timeadjustdialog.cpp
M  +1    -0    timeadjust/timeadjustdialog.h

http://commits.kde.org/kipi-plugins/7ce28b03dd7e579e58fa59f2b9ba0f56995283b2