| Summary: | Dolphin crashes when trying to open non-existing volume | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Jelle Geerts <bughunter2> |
| Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | ||
| Priority: | NOR | ||
| Version: | 2.1 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kde-baseapps/547d10aa16fb811df88a4804dc68410ebcd3ce73 | Version Fixed In: | 4.10.1 |
| Sentry Crash Report: | |||
|
Description
Jelle Geerts
2013-02-16 23:41:01 UTC
Thanks for the bug report! I can confirm the problem. More detailed backtrace from current KDE/4.10 branch: #6 0x00007f2183bea08a in QHash<QByteArray, QVariant>::value (this=0x20, akey=...) at /home/kde-4.10/qt/include/QtCore/../../src/corelib/tools/qhash.h:609 #7 0x00007f2183c28c1d in QHash<QByteArray, QVariant>::operator[] (this=0x20, akey=...) at /home/kde-4.10/qt/include/QtCore/../../src/corelib/tools/qhash.h:734 #8 0x00007f2183c2c7c9 in KStandardItem::dataValue (this=0x0, role=...) at /home/kde-4.10/kde/src/KDE/kde-baseapps/dolphin/src/kitemviews/kstandarditem.cpp:125 #9 0x00007f2183f2a751 in PlacesPanel::slotItemContextMenuRequested (this=0x27456f0, index=8, pos=...) at /home/kde-4.10/kde/src/KDE/kde-baseapps/dolphin/src/panels/places/placespanel.cpp:272 #10 0x00007f2183f2c3f8 in PlacesPanel::qt_static_metacall (_o=0x27456f0, _c=QMetaObject::InvokeMetaMethod, _id=6, _a=0x7fff0829e030) at /home/kde-4.10/kde/build/KDE/kde-baseapps/dolphin/src/placespanel.moc:83 #11 0x00007f217ea01397 in QMetaObject::activate (sender=0x28679a0, m=0x7f2183eb9b00 <KItemListController::staticMetaObject>, local_signal_index=3, argv=0x7fff0829e030) at kernel/qobject.cpp:3543 #12 0x00007f2183c1035e in KItemListController::itemContextMenuRequested (this=0x28679a0, _t1=8, _t2=...) at /home/kde-4.10/kde/build/KDE/kde-baseapps/dolphin/src/kitemlistcontroller.moc:231 #13 0x00007f2183c0c97a in KItemListController::mousePressEvent (this=0x28679a0, event=0x7fff0829fbe0, transform=...) at /home/kde-4.10/kde/src/KDE/kde-baseapps/dolphin/src/kitemviews/kitemlistcontroller.cpp:606 #14 0x00007f2183c0e34b in KItemListController::processEvent (this=0x28679a0, event=0x7fff0829fbe0, transform=...) at /home/kde-4.10/kde/src/KDE/kde-baseapps/dolphin/src/kitemviews/kitemlistcontroller.cpp:975 #15 0x00007f2183c18d85 in KItemListView::event (this=0x28401c0, event=0x7fff0829fbe0) at /home/kde-4.10/kde/src/KDE/kde-baseapps/dolphin/src/kitemviews/kitemlistview.cpp:868 Found a way to fix the crash. I hope that we can include this in KDE 4.10.1: https://git.reviewboard.kde.org/r/108989/ Good work! Nice to see the bug reporting process working so quickly. Git commit 547d10aa16fb811df88a4804dc68410ebcd3ce73 by Frank Reininghaus. Committed on 18/02/2013 at 23:58. Pushed by freininghaus into branch 'KDE/4.10'. Fix crash when clicking an action in context menu for a removed device Devices can be added and removed while the context menu is open. Sfter an action has clicked that needs to access a device, we therefore have to check if its position in the model has changed, and more importantly, if it is still there at all in order to prevent a crash. FIXED-IN: 4.10.1 REVIEW: 108989 M +24 -13 dolphin/src/panels/places/placespanel.cpp http://commits.kde.org/kde-baseapps/547d10aa16fb811df88a4804dc68410ebcd3ce73 (In reply to comment #3) > Good work! Nice to see the bug reporting process working so quickly. For bugs which can be reproduced easily, where the backtrace tells us immediately where the problematic code is and for which there is a straightforward fix, it really works quickly, yes. I wish all bugs were like this ;-) |