| Summary: | Ksysguard don't show the network traffic with the new predicaable interface names from systemd | ||
|---|---|---|---|
| Product: | [Unmaintained] ksysguard | Reporter: | dimmer <saipg.rigel.alnilam> |
| Component: | ksysguard | Assignee: | KSysGuard Developers <ksysguard-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | adsn37, apcomptec, cfeck, chaofeng111, guillaume.debure, jenya__, jenya__, kde, ludentico, nyrigadake38, richard.llom, saipg.rigel.alnilam, shaddowy2 |
| Priority: | NOR | ||
| Version: | 4.11.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kde-workspace/d09e48307f1dc204118a45a81f34102ff75fd997 | Version Fixed In: | 4.11.2 |
| Sentry Crash Report: | |||
| Attachments: |
Patch that should fix the issue
Updated patch Patch that should fix the issue |
||
|
Description
dimmer
2013-02-16 07:26:52 UTC
The same here...I tried to look up a solutions but did find only an awkward workaround. Confirmed here, using archlinux. Also affects the networkmanager plasmoid, so maybe this is more a solid bug ? Forgot to mention that I'm on Chakra Linux too, with latest updated...including Systemd 197 I meant latest updates - Linux Kernel 3.7.6-1 , KDE 4.10, Systemd 197 . *** This bug has been confirmed by popular vote. *** This is also happening on updated Manjaro KDE spin (kernel 3.7.10-0-MANJARO and systemd 197) I also (still) have this problem on latest KDE SC 4.10.3. $ systemd --version systemd 201 +PAM -LIBWRAP -AUDIT -SELINUX -IMA +SYSVINIT +LIBCRYPTSETUP +GCRYPT +ACL +XZ $ uname -a Linux chakra 3.9.2-1-CHAKRA #1 SMP PREEMPT Sun May 19 21:38:45 UTC 2013 x86_64 GNU/Linux Fixed in KDE 4.11 beta. Please reopen if it still happen to you. Well, I still don't see any change here in 4.11beta2 (4.10.90) in archlinux. Systemd version is 204. My card is listed as wlp16s0, and I use wicd for handling network connections. Reopening, as advised, then... :( Network manager here works well. Change title. Recently I installed KDE 4.11 and I don't see network traffic on Ksysguard :( I had the problem on KDE 4.10.3 and it remained with KDE 4.11.0. Running Arch Linux, kernel 3.10.6-2-ARCH, interface named enp0s25. I can confirm the bug for KDE 4.10.3 & KDE 4.11.0. I use networkmanager, not Wicd, but Ksysguard still doesn't show any network traffic for my interfaces. My interface names are "enp0s25" for ethernet and "wlp3s0" for the wireless interface. I would be glad if you could adapt Ksysguard to the new interface names of systemd. *** Bug 323850 has been marked as a duplicate of this bug. *** Can anyone who can reproduce please add the contents of /proc/net/dev and /proc/net/wireless files? $ cat /proc/net/dev
Inter-| Receive | Transmit
face |bytes packets errs drop fifo frame compressed multicast|bytes packets errs drop fifo colls carrier compressed
enp0s25: 104281854 95934 0 0 0 0 0 99 10339277 86403 0 0 0 0 0 0
wlp3s0: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
lo: 65284 498 0 0 0 0 0 0 65284 498 0 0 0 0 0 0
$ cat /proc/net/wireless
Inter-| sta-| Quality | Discarded packets | Missed | WE
face | tus | link level noise | nwid crypt frag retry misc | beacon | 22
I hope that is correct. Any other info needed?
Okay, I forgot to enable my wireless adapter in the previous message.
This time with enable ethernet & wireless adapter:
$ cat /proc/net/dev
Inter-| Receive | Transmit
face |bytes packets errs drop fifo frame compressed multicast|bytes packets errs drop fifo colls carrier compressed
enp0s25: 105407562 98157 0 0 0 0 0 132 10708656 88884 0 0 0 0 0 0
wlp3s0: 25654 157 0 0 0 0 0 0 8368 34 0 0 0 0 0 0
lo: 107308 788 0 0 0 0 0 0 107308 788 0 0 0 0 0 0
$ cat /proc/net/wireless
Inter-| sta-| Quality | Discarded packets | Missed | WE
face | tus | link level noise | nwid crypt frag retry misc | beacon | 22
wlp3s0: 0000 63. -47. -256 0 0 0 0 29 0
# cat /proc/net/dev
Inter-| Receive | Transmit
face |bytes packets errs drop fifo frame compressed multicast|bytes packets errs drop fifo colls carrier compressed
enp0s25: 16361225967 28108108 0 948 0 0 0 266534 29967671784 29692371 0 0 0 0 0 0
wlp3s0: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
lo: 24433307 211370 0 0 0 0 0 0 24433307 211370 0 0 0 0 0 0
Wireless is disabled and I am too lazy to connect to a network.
Created attachment 81964 [details]
Patch that should fix the issue
Interesting. The format of the file seems to assume there is a six-character limit for device names, because shorter names are padded with spaces. The new names, however, are indeed 7 characters long, breaking the format of the file.
Can someone please test attached patch?
Created attachment 81965 [details]
Updated patch
Sorry, previous version broke short names. This should work for short (<6), long (=6), and over-long names (>6 characters).
In the second file you rely again on some prior knowledge on field length that could go wrong later. You better scan the field with %d as well and just throw away the result. I also suggest to retrieve the value returned by sscanf() and if it is != values to parse, throw an error instead of silently failing. Created attachment 81967 [details]
Patch that should fix the issue
Parse/skip status field as suggested.
Regarding comment #22, I will leave that to ksysguard maintainers, because I do not know the code good enough to propose changes regarding error handling. I applied the patch on current git. It works as expected. I confirm that your patch fixes the problem, I compiled kdebase-workspace-4.11.0 with your patch included. It works for the total network usage, and separate ethernet & wireless connection. Thank you very much Christoph for coming up with a solution! Now I hope your fix gets included in the next KDE release ;) Git commit d09e48307f1dc204118a45a81f34102ff75fd997 by Christoph Feck. Committed on 09/09/2013 at 23:20. Pushed by cfeck into branch 'KDE/4.11'. Fix network stats with new systemd interface names FIXED-IN: 4.11.2 REVIEW: 112319 M +4 -3 ksysguard/ksysguardd/Linux/netdev.c http://commits.kde.org/kde-workspace/d09e48307f1dc204118a45a81f34102ff75fd997 Kubuntu 13.10, KDE 4.11.2, wired connection, ksysguard is not displaying any network activity. Same bug? |