| Summary: | Auto Word Completion Popup Heading Background & Text Are The Same | ||
|---|---|---|---|
| Product: | [Applications] kate | Reporter: | Félim Whiteley <felim> |
| Component: | part | Assignee: | KWrite Developers <kwrite-bugs-null> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | minor | CC: | cfeck, christoph, ilmari.lauhakangas, justin.zobel, skynet |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kate/51fb673e7f6e02a414505eb5c10b5d4493dac3d9 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Proof of fixed bug | ||
|
Description
Félim Whiteley
2013-02-15 10:23:59 UTC
From what I see, it uses ButtonText, both for the View background, as well as the Highlight background. (In reply to comment #1) > From what I see, it uses ButtonText, both for the View background, as well > as the Highlight background. That's strange as changing the popup background certainly changed it instantly to the green. I can confirm that, 4.10.2 on Linux Mint 14. Git commit 51fb673e7f6e02a414505eb5c10b5d4493dac3d9 by Joseph Wenninger. Committed on 18/07/2013 at 11:20. Pushed by jowenn into branch 'master'. This should finally fix the problem, that the first time the completion popup is shown, the first group is empty. The problem was that group titles did not get created, while m_hasGroup was empty, if a model later on in the chain caused m_hasGroup to be set, the first models didn't have valid groups -> no header text displayed. This definitely needs testing and should not be backported yet, as long as it is not being tested M +26 -2 part/completion/katecompletionmodel.cpp M +1 -0 part/completion/katewordcompletion.cpp http://commits.kde.org/kate/51fb673e7f6e02a414505eb5c10b5d4493dac3d9 Félim and Majki: Can you please follow http://kate-editor.org/get-it/ and check whether this issue now is fixed for you? Created attachment 81703 [details]
Proof of fixed bug
Kate now properly autocomplete words.
Ok, works for me, too. So let's close this. Looking at Majki's screen shot, he actually confirmed the bug is still visible on his system (the heading is black on black). Please use CheckColorRoles color scheme to see which wrong combination of fg/bg colors are used. Heading was always black? There is no "first" word - black bar is separator? http://i.imgur.com/x47kn5n.jpg And yes, I clicked "use KDE color settings" and extra word appears on black bar. For whatever reason, auto completion does no longer work on my system, so I cannot verify if this is indeed fixed. Will investigate. Git commit e553de3c3d55b1289d1ae13233ed6f9e15f36cd1 by Milian Wolff. Committed on 22/10/2013 at 11:23. Pushed by mwolff into branch 'master'. Revert "This should finally fix the problem, that the first time the completion popup is shown, the first group is empty." This reverts commit 51fb673e7f6e02a414505eb5c10b5d4493dac3d9. This completely breaks code completion with the simple word-based code completion builtin to Katepart. Probably the issue would arise for any code completion models which are not grouped at all. Conflicts: part/completion/katecompletionmodel.cpp M +1 -1 part/completion/katecompletionmodel.cpp http://commits.kde.org/kate/e553de3c3d55b1289d1ae13233ed6f9e15f36cd1 Reopened as the commit needed to be reverted. I have no idea where it comes from, but the delegate uses QPalette::ButtonText for the foreground/text color, both for unselected, as well as for selected items in the popup. Tested with CheckColorRoles color scheme. Hm, no, I was wrong. The color just looked like the button text color in CheckColorRoles theme. Still no idea how/where the text color is decided. Is "syntax" the right component? I had the impression it is used for the source highlighting descriptions. There is no heading and no problem for me. Please someone give an update on the situation. Arch Linux 64-bit Kate 16.04.2 KDE Frameworks 5.22.0 Qt 5.6.1 xcb wm I can't reproduce this issue with Kate 20.11.70. Can others please confirm this is now fixed for them as well. Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! |
