| Summary: | Taskbar vertically misplaces window titles, cuts off "g", "y", "j" etc | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma4 | Reporter: | Thomas Fischer <fischer> |
| Component: | widget-taskbar | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | annma, cfeck, francisbrwn9, kare.sars, kde, pascal, spamkill |
| Priority: | NOR | ||
| Version: | 4.10.90 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kde-workspace/e73da75872b952a3c17d50748fdfe7445a1ee020 | Version Fixed In: | 4.11 |
| Sentry Crash Report: | |||
| Attachments: |
The filename is gyjgyj.txt, but the letters' lower parts are cut off
Similar, yet less severe cut-off |
||
|
Description
Thomas Fischer
2013-02-11 09:06:23 UTC
Created attachment 77123 [details]
The filename is gyjgyj.txt, but the letters' lower parts are cut off
Created attachment 77399 [details]
Similar, yet less severe cut-off
Thank you for your report. The taskbar applet has been completely rewritten for KDE Workspaces 4.11 I cannot reproduce this bug with the new version. Please reopen this bug if you encounter this in 4.11 onwards. In fact, I am getting this bug _since_ the 4.11 rewrite. I reproduce on master, it's fine on 4.10 branch 3 different bugs in one report :) Must be a record of some sort. * There's the cuttof in kickoff. * A similar cuttoff in the taskbar in 4.10 * A new cuttoff in the taskbar in 4.11 The cutoff in kickoff is a bug, though it might be a Qt font rendering bug (not sure, haven't looked yet). The taskbar is replaced in 4.11 so the second bug is not interesting. The third one .. well, yes, this is a known issue. I'm leaving this open to remind us of that. In future, please, please, please one bug per report. *** Bug 321747 has been marked as a duplicate of this bug. *** *** Bug 321805 has been marked as a duplicate of this bug. *** The cutoff in the new taskbar depends on the height of the panel. With my set panel height I only have half the letters. The panel height has to be at least 38px to not be cutting off. *** Bug 321847 has been marked as a duplicate of this bug. *** Also seeing this in 4.10.90 (4.11b2) The new taskbar (4.10.90) now strictly follows the margins of the themes. Most themes set quite big margins, which does not work very well if you want a compact taskbar. There simply is no space left for the text. Plateau is a theme that has small margins around the task items. You can use just the "Task items" from Plateau if you use the Customized setting. I see three solutions to the problem: 1) We ask the users to use themes with less margin. 2) We go back to removing margins in stead of text and icon when the space is scarce. This has the drawback that it destroys the visual design and potentially makes it look ugly. 3) We add a compact task item to the theme standard I prefer solution 2 ;) A patch for that is attached to bug 321847 The issue isn't the margins, but 1) it first renders the text, then the frame (should be reversed) 2) the text isn't correctly centered (but the icon is) As can be seen by re-sizing the panel, nothing else in the panel uses these margins. So no the taskbar should not either. You were right, and I was wrong. The pixmap into which the text is rendered into is indeed a rect inside the margins. Review request: https://git.reviewboard.kde.org/r/111621/ Git commit e73da75872b952a3c17d50748fdfe7445a1ee020 by Christoph Feck. Committed on 23/07/2013 at 10:20. Pushed by cfeck into branch 'KDE/4.11'. Increase size of label pixmap to account for margins and shadows The text label is rendered into a pixmap which can be smaller than the actual text, because the item rect is inside some margins. This patch does two things: - increase the pixmap size by 4 pixels on top and bottom - fix the text positioning REVIEW: 111621 M +5 -5 plasma/desktop/applets/tasks/support/textlabel.cpp http://commits.kde.org/kde-workspace/e73da75872b952a3c17d50748fdfe7445a1ee020 |