| Summary: | regression with KDE 4.10: Lyrics background has the wrong colour | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Christian (Fuchs) <kde> |
| Component: | Context View/Lyrics | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | e.m.a.t.i.r.o.v, hrvoje.senjan, matej, simon.esneault, stefano, thomas |
| Priority: | NOR | Keywords: | regression |
| Version: | 2.8.0 | ||
| Target Milestone: | 2.9 | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/amarok/bdbb3a27f556c41910d3b814e5a4c73a2a93362f | Version Fixed In: | |
| Attachments: |
Screenshot showing the problem
old state 1 old state 2 Color change depending on Selection Background setting |
||
|
Description
Christian (Fuchs)
2013-02-10 21:04:22 UTC
Created attachment 77106 [details]
Screenshot showing the problem
Confirmed. Please also provide screenshot of the "old" state for clarity. Created attachment 78184 [details]
old state 1
Created attachment 78185 [details]
old state 2
Still not fixed for Amarok v2.8.0 and KDE 4.11.3 To me it seems that it's not the /lyrics/ color's background is wrong, but rather e.g. the one of the wikipedia plugin. The wikipedia background seems to be connected somehow to the global "Selection Background" setting. But it does not get exactly the color chosen there but rather some transparency/intensity-modified version thereof. In fact, all of the background colors seem to be derived from the global "Selection Background", see screenshot. Different global Selection Background settings lead to different 'one color themes'. While this feature is nice, for the page background that is not what I would expect. I'd rather expect the page background to be derived from the global "View Background" setting, just as is the case for the lyrics browser (IMO the 'correct' behavior). Created attachment 84354 [details]
Color change depending on Selection Background setting
I would like to fix this bug. Please I would like to fix this bug. Please guide me. (In reply to comment #10) > I would like to fix this bug. Please guide me. Go ahead. The source is available online, so is the documentation, as a developer you should be able to find this on your own. Please submit your code to reviewboard (steps are in the online documentation as well. Please review fix: https://git.reviewboard.kde.org/r/128246/ I believe the look and feel of every context applet should be the same, that is a lighter version of the highlight color. This is true for current track, similar artist and other applets, so I support the opinion of the original bug reporter. I fixed the bug by making the textbox of the lyrics browser transparent. The lyrics browser also has an "edit lyrics" mode. In this case, the textbox background color is switched to the default on and switched back to transparent after exiting the editing mode. If you agree with the solution, please review the code and merge my patch. Git commit bdbb3a27f556c41910d3b814e5a4c73a2a93362f by Matěj Laitl, on behalf of Stefano Pettini. Committed on 07/08/2016 at 09:42. Pushed by laitl into branch 'master'. Use transparent background for lyrics browser This makes the lyrics browser similar to every other context applet. Please note that, when editing lyrics, the default textbox background is still used. REVIEW: 128246 M +1 -0 ChangeLog M +5 -7 src/context/applets/lyrics/LyricsBrowser.cpp http://commits.kde.org/amarok/bdbb3a27f556c41910d3b814e5a4c73a2a93362f |