| Summary: | Script error: Could not parse 'VmFlags: mr mw me ac' | ||
|---|---|---|---|
| Product: | [Unmaintained] ksysguard | Reporter: | Kevin Funk <kfunk> |
| Component: | ksysguard | Assignee: | KSysGuard Developers <ksysguard-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | hrvoje.senjan, post |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kde-workspace/f41d5f969b94d3bafea56f9fcfc7db5e5d1e3f5f | Version Fixed In: | 4.10.2 |
| Sentry Crash Report: | |||
| Attachments: | Patch to fix the issue | ||
|
Description
Kevin Funk
2013-02-10 11:11:13 UTC
Well, the above comment about ksysguard working fine in 4.9.x is of course wrong. The smaps output changed a bit, so the reason is of course the more recent kernel. See http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=log;h=834f82e2aa9a8ede94b17b656329f850c1471514. Maybe it is better to just ignore unknown fields instead of throwing errors? Created attachment 77894 [details]
Patch to fix the issue
Attached is a patch to fix the issue.
Confirming that the patch resolves the problem :-) For future-proofing, it seems better to not throw an error at all for unknown matches. I opened review request https://git.reviewboard.kde.org/r/109385/ for this to find someone giving me the okay to push this ;-) (In reply to comment #4) > For future-proofing, it seems better to not throw an error at all for > unknown matches. The intend of the original code was obviously to deal explicitly with all lines in that file. I did not want to change that intend, but if the maintainer tells me this is okay with him, I sure can do that. Yep, it's okay by me, thanks :-) Oh, you *are* the maintainer... sorry, I did not know that ;-) Then I'll change it to ignore unknown lines,a dn push to stable and master. Git commit ecd6271126e7579390183f188d263722381be86a by Ralf Jung. Committed on 10/03/2013 at 11:12. Pushed by ralfjung into branch 'master'. Fix parse error in advanced memroy information for 3.8 kernels REVIEW: 109385 FIXED-IN: 4.10.2 M +1 -2 libs/ksysguard/scripts/smaps/main.js http://commits.kde.org/kde-workspace/ecd6271126e7579390183f188d263722381be86a That would be great, thank you :-) Git commit f41d5f969b94d3bafea56f9fcfc7db5e5d1e3f5f by Ralf Jung. Committed on 10/03/2013 at 11:12. Pushed by ralfjung into branch 'KDE/4.10'. Fix parse error in advanced memroy information for 3.8 kernels REVIEW: 109385 FIXED-IN: 4.10.2 M +1 -2 libs/ksysguard/scripts/smaps/main.js http://commits.kde.org/kde-workspace/f41d5f969b94d3bafea56f9fcfc7db5e5d1e3f5f |