| Summary: | On i386 system, it doesn't compile | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Luca Pizzamiglio <luca.pizzamiglio> |
| Component: | Playlists/Automated Playlist Generator | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | grave | CC: | edward.hades, stharward |
| Priority: | NOR | ||
| Version: | 2.7.0 | ||
| Target Milestone: | 2.8 | ||
| Platform: | FreeBSD Ports | ||
| OS: | FreeBSD | ||
| Latest Commit: | http://commits.kde.org/amarok/3fb39f10d902826cde3f30fafd2ea2596a008b97 | Version Fixed In: | 2.7.1 |
| Sentry Crash Report: | |||
| Attachments: | Adding the suffix on 64 bit integer constant | ||
|
Description
Luca Pizzamiglio
2013-02-06 15:55:05 UTC
Created attachment 76946 [details]
Adding the suffix on 64 bit integer constant
Very strange, why did none of the distributions report that? Apparently it does build on Linux i386 systems without problems. (In reply to comment #2) > Very strange, why did none of the distributions report that? Apparently it > does build on Linux i386 systems without problems. I guess, it's related with the old gcc version (4.2.x) FreeBSD still uses and some automatic conversion that a newer gcc adopts. Right, then I would suggest to update the Gcc version instead of asking Amarok to be compliant with outdated compilers, current is 4.7.2, your version was released over 5 years ago. (In reply to comment #4) > Right, then I would suggest to update the Gcc version instead of asking > Amarok to be compliant with outdated compilers, current is 4.7.2, your > version was released over 5 years ago. I cannot explain here all related question about what you've written, but: * FreeBSD 8 & 9 has, as default compiler, gcc 4.2.1 because newer gcc adopts GPLv3, incompatible with the BSD license. * FreeBSD 9 and Current (10) is moving to another compiler, clang. No problem raised with it. * The change I'm proposing is covered by the C99 standard, so perfectly compliant with almost every new compilers. It's a minimal modification, just add the ULL or LL suffix to a number, to specify that it's a 64 bit integer. In my personal opinion, it improves readability and compatibility. * we use, when we find a problem, to propose a patch to be integrated in the mainline, when this patch contributes to compatibility without damage the original source code (that's the case) Git commit c20d7bc1698c5322cc272d37baa7016a6477b2d8 by Edward Toroshchin. Committed on 11/04/2013 at 16:21. Pushed by hades into branch 'master'. Fix compilation error on gcc-4.2 Thanks Luca Pizzamiglio for pointing it out and providing a fix. FIXED-IN: 2.8 M +1 -0 ChangeLog M +5 -5 src/playlistgenerator/constraints/PlaylistFileSize.cpp http://commits.kde.org/amarok/c20d7bc1698c5322cc272d37baa7016a6477b2d8 Git commit 3fb39f10d902826cde3f30fafd2ea2596a008b97 by Matěj Laitl, on behalf of Edward Toroshchin. Committed on 11/04/2013 at 16:21. Pushed by laitl into branch 'v2.7.x'. Fix compilation error on gcc-4.2 Thanks Luca Pizzamiglio for pointing it out and providing a fix. FIXED-IN: 2.8 M +1 -0 ChangeLog M +5 -5 src/playlistgenerator/constraints/PlaylistFileSize.cpp http://commits.kde.org/amarok/3fb39f10d902826cde3f30fafd2ea2596a008b97 |