Summary: | "show all windows" effect should allow to close all shown windows | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Jim Jones <rauchwolke> |
Component: | general | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED INTENTIONAL | ||
Severity: | wishlist | Flags: | mgraesslin:
ReviewRequest-
|
Priority: | NOR | ||
Version: | 4.9.98 (RC3) | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
URL: | https://git.reviewboard.kde.org/r/108851/ | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
patch to allow to close all shown windows at once
patch that add the close all windows functionality |
Description
Jim Jones
2013-02-04 01:38:40 UTC
Created attachment 76894 [details]
patch to allow to close all shown windows at once
Created attachment 76895 [details]
patch that add the close all windows functionality
Honestly I don't think that's a good idea. Even if the user has configured it, it's a rather unexpected feature that clicking somewhere just closes all windows. Thinking about it even more the close window on click of window should be removed. It's from the time when we did not have the close button and has always been a hidden and dangerous feature as it is not really an expected behavior. If we would have had the close button back in that time, I'm pretty sure we would not have added the close window to the mouse actions. technically, you could probably just iterate over the windata hash. as for the feature itself, i doubt its value (how often do you perform mass window closing - eventually a specific situation that could be scripted? how long does that actually take using the close button) over its danger (from a quick look it even seems clicking anywhere would close all visible windows, not that acting on one particula affecting all others as well would be better) i agree that the closewindow action should rather be dropped and think if there was mass closing fuctionality, it should rather follow the concept of a filemanager (where you first have to select all windows with a rubberband and then "delete" them) i don't think functionality should be dropped (at least usefull),i use matlab sometimes and it shows a lot of output windows (okay, it's not matlab it's my code ;) ) and the "close all windows functionality" is really nice, at least a scripting interface to do stuff like this would be nice I'm very sorry, but I just prepared a patch (https://git.reviewboard.kde.org/r/108851/ ) to remove the close window action which implies that this is a wontfix. Sorry that your feature request turned into a "remove more features" is it possible to script this functionality? i mean to extend the "show all windows" effect (In reply to comment #7) > is it possible to script this functionality? i mean to extend the "show all > windows" effect not at the moment, but one day I hope to have a QML replacement for it. Git commit f2b7ad693e8c4ef59093287473fb07a3098775bc by Martin Gräßlin. Committed on 08/02/2013 at 11:37. Pushed by graesslin into branch 'master'. Remove close window mouse action from Present Windows effect This feature has been superseded by the close window button and as it is a rather destructive action it makes sense to remove it. Sorry to everyone who used it. REVIEW: 108851 M +0 -5 kwin/effects/presentwindows/presentwindows.cpp M +1 -2 kwin/effects/presentwindows/presentwindows.h M +0 -15 kwin/effects/presentwindows/presentwindows_config.ui http://commits.kde.org/kde-workspace/f2b7ad693e8c4ef59093287473fb07a3098775bc |