| Summary: | Corrupt base models cause synchronization hangs | ||
|---|---|---|---|
| Product: | [Applications] simon | Reporter: | Peter Grasch <me> |
| Component: | simond | Assignee: | Peter Grasch <me> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | HI | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/simon/a422221735c016463a79ff06a53cb56323818e49 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Peter Grasch
2013-02-01 18:51:21 UTC
Somehow, I can no longer reproduce it no matter how hard I try. Might have gotten fixed with the restructuring of the way the server sends responses. Still present when using unsupported base model (sphinx w/o sphinx support for example) Git commit a422221735c016463a79ff06a53cb56323818e49 by Peter Grasch. Committed on 12/06/2013 at 18:20. Pushed by grasch into branch 'master'. Fixing network communication corruption The method to process the server replies was not reentrant. As our custom thread safe tcp socket did not account for that, a race condition would occasionally mess with the read cursor. M +30 -18 simon/src/simonrecognitioncontrol/recognitioncontrol.cpp M +2 -0 simon/src/simonrecognitioncontrol/recognitioncontrol.h http://commits.kde.org/simon/a422221735c016463a79ff06a53cb56323818e49 |