Bug 313909

Bug 288721 corrected window stacking when a relative sibling window was specified, with one exception.  A window cannot be stacked lower by using an Above <sibling> reference.

Reproducible: Always

Steps to Reproduce:
Compile and run the following test application.  

/* 
 * File:   main.cpp
 * Created on January 15, 2013, 6:42 PM
 */
#include <stdlib.h>
#include <unistd.h>
#include <X11/X.h>
#include <X11/Xlib.h>
#include <X11/Xutil.h>

static const int width = 150;
static const int height = 100;
static const int visibleStepDelay = 2;

Window createManagedWindow(Display* disp, int x, int y, const char* fgColorName, const char* windowName)
{
    int screen_num = DefaultScreen(disp);

    XColor screenDef;
    XAllocNamedColor(disp, DefaultColormap(disp, screen_num), fgColorName, &screenDef, &screenDef);

    Window result = XCreateSimpleWindow(
            disp,
            RootWindow(disp, screen_num),
            x, y, width, height, 3,
            BlackPixel(disp, screen_num),   // border pixel
            screenDef.pixel                 // background pixel
    );

    XSizeHints* sizeHints = XAllocSizeHints();
    sizeHints->x = x;
    sizeHints->y = y;
    sizeHints->width = width;
    sizeHints->height = height;
    sizeHints->flags = USPosition | USSize;
    XSetWMNormalHints(disp, result, sizeHints);

    XStoreName(disp, result, windowName);

    XMapWindow(disp, result);
    XFlush(disp);
    sleep(visibleStepDelay);
    return result;
}

void stackWindow(Display* disp, Window winToStack, int aboveOrBelow, Window relativeTo)
{
    int screen_num = DefaultScreen(disp);
    XWindowChanges xwc;
    unsigned int mask;

    xwc.stack_mode = aboveOrBelow;
    mask = CWStackMode;
    if (relativeTo != 0)
    {
        xwc.sibling = relativeTo;
        mask |= CWSibling;
    }

    XReconfigureWMWindow(
            disp,
            winToStack,
            screen_num,
            mask,
            &xwc);
    XFlush(disp);
    sleep(visibleStepDelay);
}

int main(int argc, char** argv)
{
	Display * disp = XOpenDisplay("");

    // create three managed windows; window stacking (bottom to top) is 2 3 1
    Window win1, win2, win3;
    win2 = createManagedWindow(disp, 40, 40, "green", "Win 2");
    win3 = createManagedWindow(disp, 70, 70, "red",   "Win 3");
    win1 = createManagedWindow(disp, 10, 10, "blue",  "Win 1");

    // RAISE 2 by stacking it BELOW 1; window stacking now 3 2 1
    stackWindow(disp, win2, Below, win1);

    // stack 2 on bottom to restore original order; stacking now 2 3 1
    stackWindow(disp, win2, Below, 0);

    // RAISE 2 by stacking it ABOVE 3; window stacking now 3 2 1
    stackWindow(disp, win2, Above, win3);

    // stack 2 on bottom to restore original order; stacking now 2 3 1
    stackWindow(disp, win2, Below, 0);

    // LOWER 1 by stacking it ABOVE 2; stacking should be 2 1 3  [FAIL - stacking unchanged]
    stackWindow(disp, win1, Above, win2);

    // LOWER 1 by stacking it BELOW 3; stacking should be 2 1 3 [SUCCESS]
    stackWindow(disp, win1, Below, win3);

    XCloseDisplay(disp);
    return (EXIT_SUCCESS);
}
Actual Results:  
The visible steps of this application are:
  - Creates three windows, stacked (2 - 3 - 1) from bottom to top
  - Raise 2 "below 1" (3 - 2 - 1)
  - restore original stacking (2 - 3 - 1)
  - Raise 2 "above 3" (3 - 2 - 1)
  - restore original stacking (2 - 3 - 1)
  - Lower 1 "above 2" [FAILS - stacking is unchanged]
  - Lower 1 "below 3" (2 - 1 - 3)

Expected Results:  
The second to last step, with a starting stacking of (2 - 3 - 1) should have produced:
 - Lower 1 "above 2" (2 - 1 - 3)