Summary: | unloading of "Mouse Click Animation" result in kwin crash | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Dario Cambié <dariocambie> |
Component: | effects-various | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | Flags: | thomas.luebking:
ReviewRequest+
|
Priority: | NOR | ||
Version: | git master | ||
Target Milestone: | 4.10 | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kde-workspace/aacfda87c5dd6d1ddc91c57c829d19afdbaba8ef | Version Fixed In: | 4.10 |
Attachments: | Quick and dirty patch |
Description
Dario Cambié
2013-01-21 23:01:14 UTC
FYI: The same doesn't happen with Track Mouse or Magnifier. if (m_enabled) effects->stopMousePolling(); Created attachment 76620 [details]
Quick and dirty patch
The problem could be in
effects->stopMousePolling();
being called whithout a previous
effects->startMousePolling();
(I wasn't using the plugin when crash occurred).
Magnifier seems to use a private variable "polling" to address this problem, so I've copied some code from there and the issue is now gone here.
[disclaimer: I'm by no means a C++ programmer: the attachment is just a try!]
(Sorry Thomas, I've seen only now your post :D) Nevermind - happens to me all the time (hello mid-air-collision =) The patch should be ok, but the information is already encoded in m_enabled, so there's no need for another variable (yet actually had considered to propse a Effect::pollMouse(bool) and shortcut that on a flag whether we're already polling (and on destruction autostop - the current way is pretty error prone. proof: this bug) Git commit 809a7fdb63b8659c31e9ffdac41813b0787076dd by Thomas Lübking. Committed on 22/01/2013 at 00:29. Pushed by luebking into branch 'KDE/4.10'. don't stopMousePolling when not started REVIEW: 108536 M +2 -1 kwin/effects/mouseclick/mouseclick.cpp http://commits.kde.org/kde-workspace/809a7fdb63b8659c31e9ffdac41813b0787076dd Git commit aacfda87c5dd6d1ddc91c57c829d19afdbaba8ef by Thomas Lübking. Committed on 22/01/2013 at 00:29. Pushed by luebking into branch 'master'. don't stopMousePolling when not started REVIEW: 108536 M +2 -1 kwin/effects/mouseclick/mouseclick.cpp http://commits.kde.org/kde-workspace/aacfda87c5dd6d1ddc91c57c829d19afdbaba8ef |