Bug 313480

Summary:	"Leave..." item in desktop context menu should always confirm
Product:	[Unmaintained] plasma4	Reporter:	Jacob Welsh <jwelsh>
Component:	desktop	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED UNMAINTAINED
Severity:	normal	CC:	oliver.henshaw
Priority:	NOR
Version:	4.9.4
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Jacob Welsh 2013-01-19 07:25:36 UTC

There's a logout option in the desktop context menu named "Leave...". The presence of ellipses indicates to the user that there will be a confirmation dialog. However, if you've disabled "Confirm logout" in System Settings / Startup and Shutdown / Session Management, no such confirmation will be given. This breaks UI expectations and could lead to loss of unsaved work. (I still prefer to disable confirmation for the case of the kickoff menu items, which don't have ellipses and are harder to hit "by accident".)

Reproducible: Always

Steps to Reproduce:
1. Right-click the desktop (in the Default Desktop layout)
2. Click "Leave..."
Actual Results:  
The computer shuts down without warning, if "Confirm logout" is disabled.

Expected Results:  
A confirmation dialog is shown, containing different leave options.

Comment 1 Jacob Welsh 2013-01-19 07:38:21 UTC

Proposed fix at https://git.reviewboard.kde.org/r/108480/

Comment 2 Oliver Henshaw 2013-01-20 17:29:58 UTC

See bug 253405 for another take on this - a (configurable?) shorter timeout on the logout confirmation screen strikes a happy medium between confirmation of mis-clicks and prompt action.

Comment 3 Jacob Welsh 2013-01-21 23:43:56 UTC

Copying from reviewboard:
Maarten De Meyer:
This change is wrong imho. If 'Confirm logout' is disabled it should not ask for confirmation. Otherwise what's the point of that option? Showing the dialog depending on the button clicked breaks UI expectations a lot more than the presence of ellipses.
Perhaps remove the ellipses if the confirmation is disabled? (And show them in Kickoff/Tool box when enabled)
If people keep losing work due to hitting 'leave' by accident, there is a solution for that: Confirm logout.

[...]

Jacob Welsh:
I can see the logic to this, however it raises some more issues. 1) The translations for "Leave..." would have to be changed, and the "..." appended programatically depending on the setting. That might not even make sense for all languages... what about right-to-left? If not, both versions would have to be translated. And same for the kickoff items. If this is the best solution though, I guess we'll just have to deal with it. 2) The "Leave" button is not quite the same as the kickoff options, because they explicitly specify a particular form of leaving. "Leave" is not clear whether it means shutdown, logout, sleep or what. This is why it makes sense to me to always prompt: how would you like to leave? Whereas with kickoff, the user has already provided that info, so the prompt is just a timeout to prevent accidents (which I'd prefer to disable in my own setup). Other solutions to #2 might be adding explicit shutdown/logout options to the desktop context menu (cluttering it), or having the text change based on the default leave option (complicating the code quite a bit).

Comment 4 Nate Graham 2018-06-08 19:41:36 UTC

Hello!

This bug report was filed for KDE Plasma 4, which reached end-of-support status in August 2015. KDE Plasma 5's desktop shell has been almost completely rewritten for better performance and usability, so it is likely that this bug is already resolved in Plasma 5.

Accordingly, we hope you understand why we must close this bug report. If the issue described  here is still present in KDE Plasma 5.12 or later, please feel free to open a new ticket in the "plasmashell" product after reading https://community.kde.org/Get_Involved/Bug_Reporting

If you would like to get involved in KDE's bug triaging effort so that future mass bug closes like this are less likely, please read https://community.kde.org/Get_Involved#Bug_Triaging

Thanks for your understanding!

Nate Graham