Bug 313466

Summary:	Droping a folder on itself should be ignored
Product:	[Applications] dolphin	Reporter:	Frank Schaefer <fschaefer.oss>
Component:	general	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version:	2.1
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:	http://commits.kde.org/kde-baseapps/c10517314c46d511a6eb89ec7188d25d35b28959	Version Fixed In:	4.10.0
Sentry Crash Report:

Description Frank Schaefer 2013-01-18 19:16:47 UTC

When selecting a folder, it often happens to me that an error pops up saying that a folder can not be dropped on itself. The reason is a high sensitivity to mouse moves and button clicks.
Dolphin doesn't do anything wrong here, I just think that no error message is needed for dropping a folder on itself (accidently or intentionally).


Reproducible: Always

Comment 1 Frank Reininghaus 2013-01-19 10:01:31 UTC

Thanks for the report! You're right - the message is not very helpful and too intrusive. As a short-term measure, I propose to just move the message to the status bar, where is is less annoying:

git.reviewboard.kde.org/r/108483/

Comment 2 Frank Schaefer 2013-01-20 16:00:28 UTC

Thanks for looking at this !
I'm not if all error messages related to 'drag and drop' should be changed to info messages.
My personal preference would be something like

if (destdir == sourcedir) do_nothing();

Comment 3 Frank Reininghaus 2013-01-20 16:32:18 UTC

(In reply to comment #2)
> I'm not if all error messages related to 'drag and drop' should be changed
> to info messages.

Well, ideally, we would not allow drops at all if we knew that the drop would fail, and show the "drop forbidden" mouse cursor then. The patch is just an attempt to make the situation in KDE 4.10 slightly better without doing any dangerous intrusive code changes.

We'll either take this one-line change, or we won't change anything for KDE 4.10 at all. I prefer the first option.

> if (destdir == sourcedir) do_nothing();

Then I see the problem that the user might wonder why the drop failed. I think that some kind of message would be helpful in any case.

Comment 4 Frank Schaefer 2013-01-20 16:49:28 UTC

(In reply to comment #3)
> (In reply to comment #2)
> > I'm not if all error messages related to 'drag and drop' should be changed
> > to info messages.
> 
> Well, ideally, we would not allow drops at all if we knew that the drop
> would fail, and show the "drop forbidden" mouse cursor then. 

Hmm... yeah, that would be the ideal solution.

> The patch is
> just an attempt to make the situation in KDE 4.10 slightly better without
> doing any dangerous intrusive code changes.
> 
> We'll either take this one-line change, or we won't change anything for KDE
> 4.10 at all. I prefer the first option.

Sure, I'll take it, thanks ! :)

> > if (destdir == sourcedir) do_nothing();
> 
> Then I see the problem that the user might wonder why the drop failed. I
> think that some kind of message would be helpful in any case.

I don't think that users expect an explanation message when nothing happens in this case.
Should be obvious that dropping on itself will not work.

Comment 5 Frank Reininghaus 2013-01-22 06:18:37 UTC

Git commit c10517314c46d511a6eb89ec7188d25d35b28959 by Frank Reininghaus.
Committed on 22/01/2013 at 07:13.
Pushed by freininghaus into branch 'KDE/4.10'.

Make the "A folder cannot be dropped into itself" message less intrusive

Showing this message in the KMessageWidget above the view, which means
that the view contents are moved down, can be extremely annoying
according to user feedback. Just showing the message in the status bar
is probably enough.
REVIEW: 108483
FIXED-IN: 4.10.0

M  +1    -1    dolphin/src/views/dolphinview.cpp

http://commits.kde.org/kde-baseapps/c10517314c46d511a6eb89ec7188d25d35b28959