Bug 313342

Summary: new navigation-settings not applied to the current window after clicking "ok"
Product: [Applications] dolphin Reporter: aniketanvit <seeanvit>
Component: view-engine: generalAssignee: Dolphin Bug Assignee <dolphin-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: seeanvit
Priority: NOR Keywords: reproducible, usability
Version: 16.12.2   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: Version Fixed In: 4.10.1

Description aniketanvit 2013-01-16 04:33:29 UTC
In Dolphin, the navigation-setting "double-click to open files and folders" doesn't  apply to the current window on clicking  ok.  The new changes are reflected on the newly launched instances of the software but the current instance still shows the old behavour.

Reproducible: Always

Steps to Reproduce:
1.launch Dolphin File-Manager
2.Click on the "settings"  icon on the top-right side.
3.select the third-last option  "Configure Dolphin"
4.In the settings window that appeared, select "navigation" tab.
5, change the option from 'single-click/ double-click' to 'double-click/single-click' (for opening     files and folders.
6.click "ok"
7. test whether the changes have been applied to the current window or not.
Actual Results:  
the new changes (for single-click/double-click to open files and folders) are not applied to the current window. To observe the new behaviour new instance of the software has to be launched.
 

Expected Results:  
the new settings should appear in the current window of the File-Manager.
Comment 1 Frank Reininghaus 2013-01-18 11:23:02 UTC
Thanks for the bug report, confirmed.

Note: please do not set the 'reproducible' keyword yourself. This keyword means that the bug can be reproduced in a source build by the developers, which is often not the case, even if a user can reproduce the bug perfectly.
Comment 2 Frank Reininghaus 2013-02-05 19:01:19 UTC
Git commit 17eeee6b03e7beb7ba6d216b63641d63d9c894af by Frank Reininghaus, on behalf of Aniket Anvit.
Committed on 05/02/2013 at 19:58.
Pushed by freininghaus into branch 'KDE/4.10'.

Apply changes of the KGlobalSettings::singleClick() setting immediately

Fixes a regression introduced by commit
7a364cbf489af25e123d18713523151a3a53f814.

Patch reviewed and pushed by Frank Reininghaus.
FIXED-IN: 4.10.1

M  +7    -7    dolphin/src/kitemviews/kitemlistcontroller.cpp
M  +5    -6    dolphin/src/kitemviews/kitemlistcontroller.h
M  +1    -1    dolphin/src/panels/folders/folderspanel.cpp
M  +1    -1    dolphin/src/panels/places/placespanel.cpp

http://commits.kde.org/kde-baseapps/17eeee6b03e7beb7ba6d216b63641d63d9c894af