Bug 313195

Summary:	[PATCH] Upgrade from DCOP interface to DBus
Product:	[Applications] k3b	Reporter:	Piotr Michalczyk <kde>
Component:	general	Assignee:	k3b developers <k3b>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	aacid, adaptee, trueg
Priority:	NOR	Keywords:	triaged
Version:	2.0.2
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Patch for upgrading from DCOP to DBus

Description Piotr Michalczyk 2013-01-13 16:59:26 UTC

Hi,

I've managed to upgrade K3b 2.0.2 IPC from DCOP to DBus. Attached is a patch.

Short list of what I've done:
 - removed DCOP stuff and replaced it with DBus for "src/k3b*interface.(h|cpp)" files,
 - generated DBus adaptors,
 - removed references to old Qt 3.x stuff (namely Q3CString),
 - updated DBus functions code: it wasn't used for some time, things changed and this very area wasn't updated,
 - cleaned up DBus interface: there were some functions only for backward compatibility (like separate functions for erasing CD and DVD); now only one version is kept, according to current K3b API; conversion from DCOP to DBus is already a significant change in itself, so I think this is good time for breaking such backward compatibility,
 - made sure "it works for me

What I couldn't do:
 - generate adaptors on the fly with qt4_add_dbus_adaptor - I've spent some time trying, without success

Can I expect for this patch to be included in next K3b release? If yes, when do You expect it to happen? I'm asking because if You don't plan to include it in predictable future I will try to send patch to package maintainers.

Now as I earned some DBus experience, I will also gladly resolve future bugs/issues with K3b DBus, if You would like my help (but I would like to be notified about such, cause I don't watch K3b bugs list).

Regards,
Piotr

Reproducible: Always

Comment 1 Piotr Michalczyk 2013-01-13 17:00:17 UTC

Created attachment 76441 [details]
Patch for upgrading from DCOP to DBus

Comment 2 Christoph Feck 2013-01-20 03:46:22 UTC

Thanks Piotr for the patch. Unfortunately, k3b currently has no maintainer, so unless you plan to step up, do not expect it to be integrated soon.

Comment 3 Piotr Michalczyk 2013-01-21 13:02:30 UTC

(In reply to comment #2)
> Thanks Piotr for the patch. Unfortunately, k3b currently has no maintainer,
> so unless you plan to step up, do not expect it to be integrated soon.

Thanks Christoph,

I think I could dedicate some time to improving K3b. Looking at the number of bug reports with some of them dated as far as 2006, I don't think it could be possible to clean them up quickly. But I could start from incorporating users' patches and making simple fixes at least.

Can You point me in a proper direction to participate in working on K3b?

Regards.

Comment 4 Christoph Feck 2013-04-22 19:41:12 UTC

k3b has two faces. There is the KDE specific code for UI, file handling etc., where anything written in the KDE beginners dev guide applies. It has many pointers for help. See http://community.kde.org/Getinvolved/development

The other side is the cdrecord specific stuff, for which you need to look for help elsewhere. Maybe there is a mailing list for cdrecord.

Comment 5 Albert Astals Cid 2014-09-28 00:41:54 UTC

Piotr, we're starting a "Love project" for K3b, you may want to read https://community.kde.org/Gardening and https://community.kde.org/Gardening/K3b

Comment 6 Albert Astals Cid 2014-09-29 21:30:51 UTC

I tried applying the patch and there's big chunks that don't apply. Could you remake it? Also it'd be much better if you upload it to http://reviewboard.kde.org/

Comment 7 Andrew Crouthamel 2018-09-25 03:31:41 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

Comment 8 Andrew Crouthamel 2018-10-27 03:35:42 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!