Summary: | regression: post it (annotation) is rotated on pdfs with landscape | ||
---|---|---|---|
Product: | [Applications] okular | Reporter: | suse |
Component: | general | Assignee: | Fabio D'Urso <fabiodurso> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aacid, fabiodurso, fraph24 |
Priority: | NOR | ||
Version: | 0.15.97 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/okular/119cd27c081ecf9a840b1b4778d3f27c85f7ca52 | Version Fixed In: | 4.11.0 |
Attachments: |
wrongly rotated annotation (post it)
Page from a file that displays this issue |
Description
suse
2013-01-13 12:42:09 UTC
Created attachment 76436 [details]
wrongly rotated annotation (post it)
Please attach the pdf file you are using to reproduce the problem. I see, I've been able to reproduce it with some PDF documents I have (mostly slides), for example: http://www.dmi.unict.it/~fstanco/lezioni_IEM_2007_2008/quarta_parte_colori.pdf Seems my Poppler rendering code for inline text annotations has some issues with /Rotated pages. A quick test shows that popup annotations' icon is also affected (it is displayed rotated), and I guess sound and fileattachment icons are affected too, since their code is very similar in Poppler. Anyway, this is a Poppler bug. I'll have a look tomorrow. Thank you for reporting :) @Albert: I'm closing this bug, but I'm not opening a Poppler bug because I plan to fix it myself very soon. According some other tests I've made some days ago, it's not a Poppler issue only, because Okular will need to be patched too (we'll need to set the FixedRotation flag in new inline text annotations). Since I'll be a bit busy in the next days and I won't be able to work on it, I'm reopening this bug as a remainder. *** Bug 314249 has been marked as a duplicate of this bug. *** Created attachment 77786 [details] Page from a file that displays this issue Patches are almost ready. Btw, seems that the file linked in comment #3 has been silently replaced with a new version where this issue doesn't happen. The old version can be found at http://web.archive.org/web/20100928134843/http://www.dmi.unict.it/~fstanco/lezioni_IEM_2007_2008/quarta_parte_colori.pdf My bad, I should have attached it instead of posting a link. Since that file is too big, I've extracted the first page and I'm attaching it. Git commit 6efedc7beab3d0ad34b51ac1947acec840564f6f by Fabio D'Urso. Committed on 26/06/2013 at 19:47. Pushed by fabiod into branch 'master'. poppler: Comply with new rules in API calls about FixedRotation annotations See patch 0006 in http://lists.freedesktop.org/archives/poppler/2013-April/010214.html M +4 -1 generators/poppler/annots.cpp http://commits.kde.org/okular/6efedc7beab3d0ad34b51ac1947acec840564f6f Git commit 119cd27c081ecf9a840b1b4778d3f27c85f7ca52 by Fabio D'Urso. Committed on 26/06/2013 at 19:53. Pushed by fabiod into branch 'master'. Set FixedRotation flag on new inline text annotations FIXED-IN: 4.11.0 M +1 -0 ui/pageviewannotator.cpp http://commits.kde.org/okular/119cd27c081ecf9a840b1b4778d3f27c85f7ca52 These patches align new text annotations to the default orientation of the document (same as View -> Orientation -> Original orientation). Note that only *new* text annotations are affected. Also, poppler 0.24 (not yet released) is required. |