Summary: | DrKonqi should use /etc/os-release as another way of getting Linux distribution information in addition to lsb_release | ||
---|---|---|---|
Product: | [Applications] drkonqi | Reporter: | Jekyll Wu <adaptee> |
Component: | general | Assignee: | Jekyll Wu <adaptee> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | butirsky, mail |
Priority: | NOR | ||
Version: | 2.1.5 | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kde-runtime/215d23ea129804488dc0b8f08b6455a5840ea454 | Version Fixed In: | 4.11.0 |
Sentry Crash Report: |
Description
Jekyll Wu
2013-01-11 14:22:42 UTC
Extra note: Although /etc/os-release is proposed by systemd, some non-systemd distributions (debian, gentoo, slackware) also have adopted it. I'm not a fan of systemd, but I agree /etc/os-release is a good idea. (In reply to comment #0) > So I would propose adding /etc/os-release as *another* way of getting Linux > distribution information in addition to the lsb_release script. It should be > considered only when lsb_release is unavailable or doesn't give useful > information. Don't propose. Implement it! I'll be waiting for the review request... ;) (In reply to comment #2) > (In reply to comment #0) > > So I would propose adding /etc/os-release as *another* way of getting Linux > > distribution information in addition to the lsb_release script. It should be > > considered only when lsb_release is unavailable or doesn't give useful > > information. > > Don't propose. Implement it! > I'll be waiting for the review request... ;) Of course I will also start implementing it :) Write this report so that the proposal can be easily tracked. Git commit 215d23ea129804488dc0b8f08b6455a5840ea454 by Jekyll Wu. Committed on 27/01/2013 at 03:23. Pushed by jekyllwu into branch 'master'. Use /etc/os-release as another source for Linux distribution information This will not replace lsb_release. /etc/os-release will only be referred to when lsb_release is not available or doesn't return good result at runtime. REVIEW: 108352 FIXED-IN: 4.11.0 M +89 -38 drkonqi/systeminformation.cpp M +3 -0 drkonqi/systeminformation.h http://commits.kde.org/kde-runtime/215d23ea129804488dc0b8f08b6455a5840ea454 |