Bug 312988

Summary:	Menus colors problems with gtk-3.7
Product:	[Plasma] Oxygen	Reporter:	nucleo <nucleo>
Component:	gtk3-engine	Assignee:	Hugo Pereira Da Costa <hugo.pereira.da.costa>
Status:	RESOLVED FIXED
Severity:	normal	CC:	b7.10110111, hugo.pereira.da.costa, rdieter, web
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	menu in gpk-application menu after applying patches broken background about avidemux

Description nucleo 2013-01-10 02:24:18 UTC

Menus items have different colors with gtk3-3.7.4.

Reproducible: Always

Actual Results:  
See screenshot with gpk-application.

Comment 1 nucleo 2013-01-10 02:25:28 UTC

Created attachment 76354 [details]
menu in gpk-application

Comment 2 nucleo 2013-01-10 02:27:55 UTC

oygen-gtk3 version 1.1.1.

Comment 3 nucleo 2013-01-10 02:43:01 UTC

Manu looks fine with Adwaita and Raleigh themes.

Comment 4 Hugo Pereira Da Costa 2013-01-10 09:44:21 UTC

Can reproduce.
Same is true with menubars.
Since it was not there with gtk3.6, this is (yet another) gtk3 "regression" (or feature).
Will investigate ...

Comment 5 Hugo Pereira Da Costa 2013-01-10 10:06:28 UTC

Git commit f386f3a9c853dd1d6009f0e5bf3e3fc36231ddd6 by Hugo Pereira Da Costa.
Committed on 10/01/2013 at 11:05.
Pushed by hpereiradacosta into branch 'gtk3'.

Render menu item rect only if state is prelight.

M  +8    -0    src/oxygenthemingengine.cpp

http://commits.kde.org/oxygen-gtk/f386f3a9c853dd1d6009f0e5bf3e3fc36231ddd6

Comment 6 Hugo Pereira Da Costa 2013-01-10 10:07:24 UTC

That fixes it.
There are other "margins" issues for menus (they are way too small).
I'll also try to fix.

Comment 7 Hugo Pereira Da Costa 2013-01-10 10:46:08 UTC

Git commit 27f05974f0b6ecf680dbe7101e6941189ea9ec58 by Hugo Pereira Da Costa.
Committed on 10/01/2013 at 11:15.
Pushed by hpereiradacosta into branch 'gtk3'.

added proper padding and borderwidth for GtkMenu in Gtk 3.7.0
moved all GtkMenu related paddings from gtk.css to oxygenqtsettings, to deal with gtk3 versions.

M  +0    -5    rc/gtk.css
M  +31   -1    src/oxygenqtsettings.cpp

http://commits.kde.org/oxygen-gtk/27f05974f0b6ecf680dbe7101e6941189ea9ec58

Comment 8 Hugo Pereira Da Costa 2013-01-10 10:47:33 UTC

PS: thanks for posting the bug ;)

Comment 9 nucleo 2013-01-11 16:39:46 UTC

Created attachment 76391 [details]
menu after applying patches

Menu looks good after applying commits f386f3a9c853dd1d6009f0e5bf3e3fc36231ddd6 and 27f05974f0b6ecf680dbe7101e6941189ea9ec58.

Comment 10 nucleo 2013-01-11 16:41:01 UTC

Created attachment 76392 [details]
broken background

But after menu closed it leaves broken background.

Comment 11 Hugo Pereira Da Costa 2013-01-11 16:43:26 UTC

@Nucleo
That's probably something different
(which I could not reproduce, as far as I can tell).
Seems like part of the window is not updated properly anymore. Does the problem persist if you (for instance) 
- minimize/maximize the window ? 
- resize the window ?

Comment 12 Hugo Pereira Da Costa 2013-01-11 16:55:24 UTC

PS: what's the application in the screenshot ? 
Does it happen, with all applications ?

Comment 13 nucleo 2013-01-11 17:05:57 UTC

Created attachment 76393 [details]
about avidemux

This is gpk-application (gnome packagekit).
Resizing don't update window, it updated after minimize/maximize.
Similap problem in About window in avidemux-gtk, when License pressed window resized but part of window not updated.
All of this problems fixes -DENABLE_INNER_SHADOWS_HACK=0.