| Summary: | Procedure to fix and upload namedays holidays for the Greek language | ||
|---|---|---|---|
| Product: | [Applications] kdepimlibs | Reporter: | Dimitrios Glentadakis <dglent> |
| Component: | kholidays | Assignee: | John Layt <jlayt> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | antkoul, auxsvr, kdepim-bugs |
| Priority: | NOR | ||
| Version: | 4.9 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| URL: | https://bugs.kde.org/show_bug.cgi?id=312744 | ||
| Latest Commit: | http://commits.kde.org/kdepimlibs/9b47419ccbf40fafc189f9f6bbf1e49d90571915 | Version Fixed In: | 4.13.1 |
| Sentry Crash Report: | |||
| Bug Depends on: | |||
| Bug Blocks: | 312744 | ||
| Attachments: |
Holidays file for Greece
Holidays file for Greece (2013/04/27) korganizer Greek holidays file (correct dates) |
||
|
Description
Dimitrios Glentadakis
2013-01-07 19:45:59 UTC
Only plan2 needs an update. Then you can attach the updated file to this report. Don't forget to add your name and if possible an official source where we can compare the dates. Created attachment 76556 [details] Holidays file for Greece I edited the file from here: http://quickgit.kde.org/?p=kdepimlibs.git&a=blob&h=6b0def16940135348370afa7b0eb8f55d3a192e8&hb=4f86bbd08abbe5f390765a933c97d8a1b3e280dc&f=kholidays%2Fholidays%2Fplan2%2Fholiday_gr_el In some namedays there are some rules where i dont know how to define them It is about the namedays in lines 131, 136, 314 (In reply to comment #2) > It is about the namedays in lines [del]131, 136[/del], 314 It is about the namedays in lines 145, 149, 314 Created attachment 79485 [details]
Holidays file for Greece (2013/04/27)
Fixed the nameday of Chloe on February 13
I see eg in the French file with the mothers day that the moveable feast date is defined with a specific way: : Mothers' day, move if clashes with Pentecost "Fête des mères" ( ( [last sunday in may] == ([easter] + 49 days) ) ? [first sunday in june] : [last sunday in may] ) : or 'first sunday in june' if same day as Pentecôte Do i have to do the same with the Greek file ? For now, i wrote the rules of the moveable feast days in a python way at least to be understood by the maintainer Thanks Short update, we're currently reviewing the updated holiday file you provided. We're trying to figure how to deal with 'Γεώργιος, Γεωργία' & '"Μάρκος"' Created attachment 86260 [details]
korganizer Greek holidays file (correct dates)
Hello.
I fixed the special dates Dimitrios had trouble with and some formatting inconsistencies.
This new file works correctly with korganizer 4.12.4.
Tested in 4.13.0 with success Thanks Marios ! Just confirming, Marios' updated file fixes everything, at least for the 3 next years that I checked. Git commit 9b47419ccbf40fafc189f9f6bbf1e49d90571915 by Christophe Giboudeaux. Committed on 27/04/2014 at 09:12. Pushed by cgiboudeaux into branch 'KDE/4.13'. Update the Greek holidays file FIXED-IN: 4.13.1 M +47 -42 kholidays/holidays/plan2/holiday_gr_el http://commits.kde.org/kdepimlibs/9b47419ccbf40fafc189f9f6bbf1e49d90571915 |