| Summary: | digiKam uses lens crop factor, not camera's [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Roman I Khimov <rik> |
| Component: | Plugin-Editor-LensCorrection | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | CLOSED FIXED | ||
| Severity: | normal | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version: | 2.6.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/digikam/613d004121682d122e9ea7fd9041a7bbc49acb89 | Version Fixed In: | 3.0.0 |
| Attachments: | Patch to fix the problem | ||
|
Description
Roman I Khimov
2013-01-06 17:39:53 UTC
Created attachment 76256 [details]
Patch to fix the problem
Git commit 613d004121682d122e9ea7fd9041a7bbc49acb89 by Gilles Caulier. Committed on 07/01/2013 at 11:34. Pushed by cgilles into branch 'master'. Apply patch #76256 from Roman I Khimov to use crop factor from camera, not from lens data. Lens crop factor in DB only tells us which crop factor was used for lens calibration data, but it has nothing to do with shots made on random user's camera. So the default behaviour should be to use camera's crop factor and only fallback to lens data if there in no data present for camera. As "this should not happen" it's appropriate to spit out some debug message in this case. Ref: http://lensfun.berlios.de/manual/el_lens.html Ref: http://lensfun.berlios.de/manual/el_camera.html Related: bug 312764, bug 253941, bug 266204, bug 267613, bug 281783, bug 284708 FIXED-IN: 3.0.0 CCMAIL: roman@khimov.ru M +2 -1 libs/dimg/filters/lens/lensfuncameraselector.cpp M +1 -1 libs/dimg/filters/lens/lensfuniface.cpp http://commits.kde.org/digikam/613d004121682d122e9ea7fd9041a7bbc49acb89 Patch applied, thanks, closing. |