| Summary: | Crop factor is being used as scale factor [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Roman I Khimov <rik> |
| Component: | Plugin-Editor-LensCorrection | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | CLOSED FIXED | ||
| Severity: | normal | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version: | 2.6.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/digikam/70cf9beaac9996c219f988d8ae74d75dc253c0ad | Version Fixed In: | 3.0.0 |
| Attachments: | Patch to fix the problem | ||
|
Description
Roman I Khimov
2013-01-06 17:37:05 UTC
Created attachment 76255 [details]
Patch to fix the problem
Git commit 70cf9beaac9996c219f988d8ae74d75dc253c0ad by Gilles Caulier. Committed on 07/01/2013 at 11:39. Pushed by cgilles into branch 'master'. Apply patch #76255 from Roman I Khimov to don't pass crop factor as scale factor to lensfun. Sixth parameter to Initialize() is actually a scale factor which has nothing in common with crop factor. I think it's safe to assume that we want no scaling from lensfun and thus use the value of one. Ref: http://lensfun.berlios.de/manual/structlfModifier.html Related: bug 312764, bug 253941, bug 266204, bug 267613, bug 281783, bug 284708 FIXED-IN: 3.0.0 CCMAIL: roman@khimov.ru M +1 -1 libs/dimg/filters/lens/lensfunfilter.cpp http://commits.kde.org/digikam/70cf9beaac9996c219f988d8ae74d75dc253c0ad Roman, Thanks a lots for your investiguations and patches around digiKam Lensfun interface. Gilles Caulier Patch applied, thanks, closing. |