Summary: | Does not build with libktorrent master | ||
---|---|---|---|
Product: | [Applications] kget | Reporter: | Christoph Feck <cfeck> |
Component: | torrent | Assignee: | KGet authors <kget> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | david.narvaez, joris.guisson |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.10 |
Description
Christoph Feck
2013-01-03 14:52:12 UTC
I happen to have both masters checked out so I did the testing and it works. I added the specific tests to the reviewboard. Still, I'd wait for Lukas to give it a go. Hey! :) Nice to see a patch here already. I wonder though if we should support the old version in the code as well, there might be distributions who use an old libktorrent. This has been done in a few cases in this codebase already. http://websvn.kde.org/trunk/KDE/kdenetwork/kget/transfer-plugins/bittorrent/bttransferhandler.cpp?view=markup (line 82) Lukas True. I actually forgot to ask if there was going to be any version bump for libKTorrent after this API breakage. Still, I don't see any way to match versions in the CMakeList.txt for kdnetwork yet - that should probably be fixed. Yes, a version bump is necessary from the libktorrent side, although I would suggest then doing the if-thing inside the code not the CMakeLists.txt :) Lukas I may be wrong, but I think it should compile with older libktorrent, too. As far as I see, Joris only removed one of two similar functions. You are right even :) https://projects.kde.org/projects/extragear/network/libktorrent/repository/revisions/749a4c5532d68b879a1dc37adf7faecd2e11bda4 That is the commit and it just removes this method and keeps the other one. Then I'd say +1 for commiting! Lukas Confirmed, I built with a previous version of libktorrent. So, will this change go to 4.10 too? I would support that. It seems like a rather trivial fix. :) Lukas SVN commit 1330900 by narvaez: Switching to an equivalent init call to libKTorrent to prevent future API breakage. CCMAIL: christoph@maxiom.de FIXED-IN: 4.10 M +2 -2 bttransfer.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1330900 |