| Summary: | Connection list filter doesn't work with localized strings | ||
|---|---|---|---|
| Product: | Network Management | Reporter: | Kai Uwe Broulik <kde> |
| Component: | Plasma Widget | Assignee: | Sebastian Kügler <sebas> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jgrulich, lamarque, wstephenson |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 0.9.0.7 | |
I pushed the commit with the fix. http://commits.kde.org/networkmanagement/e4b705b75c35397fd350bdb4cbbfff40028a3f95 One problem remains though: when Plasma is first started/restarted, the list is empty, I have to switch to another tab and back to Connections to get my list This problem is caused because the filter is applied when the currentTabChanged signal is catched. This does not happen when you first start the applet. I told lamarque about this problem. I could look at it tomorow and try to fix it. (In reply to comment #3) > This problem is caused because the filter is applied when the > currentTabChanged signal is catched. This does not happen when you first > start the applet. I told lamarque about this problem. I could look at it > tomorow and try to fix it. That's already fixed in commit 87c8bb47238e95ca2b05a20df042f18f5448985b |
With the new QML plasmoid that got just merged, my connection list stays empty. The cause is: applet/qml/ConnectionsTabWidget.qml uses eg. i18n("Connections") for TabButton text and then fires connectionsListModel.setFilter(currentTab.text) when the selected tab changes. The ConnectionsListModel::setFilter in applet/connectionlistmodel.cpp does a string compare such as tabName == "Connections" which doesn't work when the TabButton Text is translated to eg. "Verbindungen". Reproducible: Always