Bug 312146

Summary: limit size of the last window in the present windows effect
Product: [Plasma] kwin Reporter: Jin Liu <m.liu.jin>
Component: effects-overviewAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: ad.liu.jin, ba.tahaaziz, nate
Priority: NOR Keywords: usability
Version First Reported In: 4.8.4   
Target Milestone: ---   
Platform: Debian unstable   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=303932
Latest Commit: https://invent.kde.org/plasma/kwin/commit/0931e4f8cc1cd5f7a6c64e0f78f6e58371b6a7da Version Fixed In: 5.23
Sentry Crash Report:

Description Jin Liu 2012-12-24 04:41:29 UTC 
If I closed all other windows in the Present Windows effect, so the only window remaining is a maximized one, it's rendered as maximized, with "close" button in upper-right and app icon in bottom-right. This makes it hard to tell if the effect end or not (because the button/icon is out of eye focus area).

So far it's the same problem as in:
https://bugs.kde.org/show_bug.cgi?id=303932
However, my suggestion is: don't render the last window in its original size. If it's still rendered in half size as in the case of two windows, then it'll be very obvious to the user that the effect has not ended.

A (more daring) suggestion is to not resizing remaining windows at all, when window is closed in the effect -- keep them at the same size when the effect is triggered. This way, closing multiple windows won't trigger constant re-layout so it's easier to the eye.

Reproducible: Always

Steps to Reproduce:
1. Open two maximized windows.
2. Trigger Present Windows effect.
3. Close one window.
Actual Results:  
The remaining window is shown maximized. Confusing if the effect has ended or not.

Expected Results:  
The remaining window is shown in half size. Obvious to the user that the effect is still on.
Comment 1 Nate Graham 2021-08-19 15:20:13 UTC 
*** Bug 440081 has been marked as a duplicate of this bug. ***
Comment 2 Bug Janitor Service 2021-08-19 17:09:44 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/1279
Comment 3 Vlad Zahorodnii 2021-08-26 16:11:54 UTC 
Git commit 0931e4f8cc1cd5f7a6c64e0f78f6e58371b6a7da by Vlad Zahorodnii.
Committed on 26/08/2021 at 16:11.
Pushed by vladz into branch 'master'.

effects/overview: Pad screen borders in qml

This makes it easier to spot if the effect is activated while there is
only one maximized window.

Note that anchors.margins cannot be used unfortunately as it won't take
effect until the ExpoLayout item is fully constructed. It may take a
couple of cycles for the geometry to settle down, which makes reasoning
about how the effect works difficult.

M  +5    -5    src/effects/overview/expolayout.cpp
M  +1    -0    src/effects/overview/qml/ScreenView.qml
M  +5    -1    src/effects/overview/qml/WindowHeap.qml

https://invent.kde.org/plasma/kwin/commit/0931e4f8cc1cd5f7a6c64e0f78f6e58371b6a7da
Comment 4 Jin Liu 2021-11-16 07:48:41 UTC 
The padding is lost in the current version. Not sure if it's intended or not.

Distro: archlinux
Plasma: 5.23.3
KDE Framework: 21.08.3
QT: 5.15.2
Comment 5 Nate Graham 2021-11-16 17:56:23 UTC 
This is fixed in the *Overview* effect. Present Windows is deprecated and will be replaced with the Overview effect once it's fully ready. The Present Windows effect isn't being developed anymore.