Bug 311976

Summary:	Kate 3.9.90 on KDE 4.9.90 does not save files when I use the window exit
Product:	[Applications] kate	Reporter:	Samuel <sbc_hates_spam>
Component:	application	Assignee:	KWrite Developers <kwrite-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	christoph, sbc_hates_spam
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
URL:	http://www.kubuntuforums.net/showthread.php?61403-KDE-4-9-90-Anomalous-Behaviour
Latest Commit:	http://commits.kde.org/kate/5fbd023fc46ecc57a6772be2aa04f532e8426f43	Version Fixed In:
Sentry Crash Report:

Description Samuel 2012-12-20 10:33:13 UTC

If I edit a text file and use either Ctrl+Q or the window exit tab, the edit changes are not saved.  If I use Ctrl+w or Ctrl+s the edit changes are saved.

For speed I use the window exit with Kate to save a file but this no longer works as in the previous version.

Reproducible: Always

Steps to Reproduce:
1. open a text file with Kate 3.9.90
2. edit the file and exit using the window exit tab with the save option
3. open the text file again and note that the edit done in step 2 is not saved.
Actual Results:  
Changes to a file edited by Kate 3.9.90 are not saved with Ctrl+Q or window exit when the save option is chosen.

Expected Results:  
Kate should save changes made to a file when using Ctrl+Q or window exit when the save option is chosen.

Comment 1 Christoph Cullmann 2013-01-03 19:33:14 UTC

Git commit 0f567e9782aa08a28d6d3bc2ef38042ebc42c1f6 by Christoph Cullmann.
Committed on 03/01/2013 at 20:32.
Pushed by cullmann into branch 'master'.

fix save/not-save buttons

M  +8    -8    kate/app/katesavemodifieddialog.cpp

http://commits.kde.org/kate/0f567e9782aa08a28d6d3bc2ef38042ebc42c1f6

Comment 2 Christoph Cullmann 2013-01-03 19:39:34 UTC

Added Review-Request for Backport.
https://git.reviewboard.kde.org/r/108134/

Comment 3 Christoph Cullmann 2013-01-03 20:10:26 UTC

Git commit 5fbd023fc46ecc57a6772be2aa04f532e8426f43 by Christoph Cullmann.
Committed on 03/01/2013 at 20:32.
Pushed by cullmann into branch 'KDE/4.10'.

fix save/not-save buttons

M  +8    -8    kate/app/katesavemodifieddialog.cpp

http://commits.kde.org/kate/5fbd023fc46ecc57a6772be2aa04f532e8426f43

Comment 4 Samuel 2013-01-08 10:56:00 UTC

Thanks very much.  Working well.  Just got back from holidays and KDE was updated to 4.9.97.  Well done - love the  new improvements.  Keep up the good work.


________________________________
 From: Christoph Cullmann <cullmann@kde.org>
To: sbc_hates_spam@yahoo.com.au 
Sent: Friday, 4 January 2013 6:03 AM
Subject: [Bug 311976] Kate 3.9.90 on KDE 4.9.90 does not save files when I use the window exit
 
https://bugs.kde.org/show_bug.cgi?id=311976

Christoph Cullmann <cullmann@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/kate
                   |                            |/0f567e9782aa08a28d6d3bc2ef
                   |                            |38042ebc42c1f6

--- Comment #1 from Christoph Cullmann <cullmann@kde.org> ---
Git commit 0f567e9782aa08a28d6d3bc2ef38042ebc42c1f6 by Christoph Cullmann.
Committed on 03/01/2013 at 20:32.
Pushed by cullmann into branch 'master'.

fix save/not-save buttons

M  +8    -8    kate/app/katesavemodifieddialog.cpp

http://commits.kde.org/kate/0f567e9782aa08a28d6d3bc2ef38042ebc42c1f6