Summary: | after file-name search and another another tab is opened, the new tab can't close search | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | martien friedeman <martien.friedeman> |
Component: | search | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | emmanuelpescosta099, ntrrgc |
Priority: | NOR | Keywords: | reproducible |
Version: | 2.0 | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kde-baseapps/54208a66a07a92af968a083a800666edc9e5756f | Version Fixed In: | 4.13.0 |
Description
martien friedeman
2012-12-19 21:26:44 UTC
Thanks for the bug report. I can reproduce this bug in Dolphin 2.1.95 / KDE 4.9.95 and in Dolphin Git Master *** Bug 329606 has been marked as a duplicate of this bug. *** Git commit 54208a66a07a92af968a083a800666edc9e5756f by Emmanuel Pescosta. Committed on 28/03/2014 at 17:48. Pushed by emmanuelp into branch 'KDE/4.13'. When you open a new tab while the search mode is enabled, the newly opened tab also starts the same search (Because new tab is opened with the current view url), but the search box is in read-only mode. So you cannot close the search bar nor edit the search text. This patch fixes this by parsing the search url. The value of the "search" parameter is used as search text and the value of the "url" parameter is used for the search path ("root" folder for the search when "Search from here" mode is enabled). In case of Baloo search urls, we use Baloo::Query::fromSearchUrl. Removed everything related to read only mode in DolphinSearchBox, not needed anymore. REVIEW: 111968 FIXED-IN: 4.13.0 M +6 -24 dolphin/src/dolphinviewcontainer.cpp M +109 -0 dolphin/src/search/dolphinfacetswidget.cpp M +8 -0 dolphin/src/search/dolphinfacetswidget.h M +47 -29 dolphin/src/search/dolphinsearchbox.cpp M +10 -13 dolphin/src/search/dolphinsearchbox.h http://commits.kde.org/kde-baseapps/54208a66a07a92af968a083a800666edc9e5756f |